audio: crossover: fix the mistake of sink stream pointer #5585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to fix the mistake of using audio_stream_read_frag* while getting output sink buffer pointer. Signed-off-by: Andrula Song <xiaoyuan.song@intel.com>
andrula-song
requested review from
chiang831,
cujomalainey and
johnylin76
as code owners
singalsu
approved these changes
Mar 23, 2022
Member
|
@andrula-song @singalsu is the crossover on your list to deprecate the old frag API ? |
cujomalainey
approved these changes
Mar 23, 2022
Contributor
Author
yes, I have rewrite code to optimize the read/write frag, but there is no existed testcase to test it. Need more time to see the correctness and optimization |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix the mistake of using audio_stream_read_frag* while
getting output sink buffer pointer.
Signed-off-by: Andrula Song xiaoyuan.song@intel.com