ipc4: base_fw: Simplify firmware version type in basefw_get_dsp_prope… #5606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rties Use the sizeof on the fw_version array to remove the magic number for the size calculation and drop the address modifier for the data pointer. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
ujfalusi
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Contributor
Author
|
The build failures are not related to the PR as far as I can see (TGL xcc did built the base_fw.o fine, I'm not sure what is failing. BYT xcc fail "License checkout failed"). |
lgirdwood
approved these changes
Mar 28, 2022
Member
This is an unrelated error, will rerun. |
Member
|
SOFCI TEST |
RanderWang
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rties
Use the sizeof on the fw_version array to remove the magic number for the
size calculation and drop the address modifier for the data pointer.
Signed-off-by: Peter Ujfalusi peter.ujfalusi@linux.intel.com