pipeline: do not reschedule pipe task if already in target state #5627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When processing a trigger action in pipeline_task_cmd(), do not return SOF_TASK_STATE_RESCHEDULE if the pipeline is already in requested ACTIVE state. The unnecessary reschedule can cause scheduling bubbles in topologies with mixer fed by multiple source pipelines. When the frontend pipelines are released from pause or started, the connected pipelines that are already running, need to keep running. A reschedule will cause a gap in scheduling in of the downstream pipeline(s) mixer feeds. This fix is not sufficient on its own, but is part of the fixes to address: thesofproject#5469 Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Collaborator
Author
|
We might want to wait until @lyakh can review this. This is touching code Guennadi added fairly recently. |
lyakh
approved these changes
Apr 4, 2022
lgirdwood
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing a trigger action in pipeline_task_cmd(), do
not return SOF_TASK_STATE_RESCHEDULE if the pipeline is already
in requested ACTIVE state.
The unnecessary reschedule can cause scheduling bubbles in
topologies with mixer fed by multiple source pipelines. When
the frontend pipelines are released from pause or started,
the connected pipelines that are already running, need to keep
running. A reschedule will cause a gap in scheduling in
of the downstream pipeline(s) mixer feeds.
This fix is not sufficient on its own, but is part of the fixes
to address: #5469
Signed-off-by: Kai Vehmanen kai.vehmanen@linux.intel.com