xtensa-build-zephyr.py: forbid shell=True

[marc-hb]

The entire purpose of replacing the older shell script with Python was
to achieve cross platform compatibility. shell=True would lose that.

See also
https://docs.python.org/3/library/subprocess.html#security-considerations

Signed-off-by: Marc Herbert marc.herbert@intel.com

[lgirdwood]

@aborisovich any comments and can you confirm this is good on Windows ? Thanks.

[aborisovich]

@aborisovich any comments and can you confirm this is good on Windows ? Thanks.

Just build TGL as a test, works fine. I am not sure we should add "manual code restrictions" like this one.
I think it would be better to just prevent shell=True on code reviews but ok, it does not matter that much.

[marc-hb]

I think it would be better to just prevent shell=True on code reviews but ok

Thanks @aborisovich

Code reviews are critical but also... human: unreliable, not immediate, scarce,... :-)

If there is some real shell=True need later (none yet AFAIK), then this should provide a simple solution:

if os == windows:
    log(windows_cmd)
    subprocess.run(windows_cmd, shell=True,...)