Audio: Dcblock: Optimize dcblock read/write frags #5871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The audio processing times for a 15s long stereo 48 kHz clip on GLK device are shown in next plot. The saving is in average 2 us or 0.77 MCPS, decrease about 14%. Upper row is after optimization, averi, lower row is before optimization. |
andrula-song
requested review from
lgirdwood and
singalsu
and removed request for
lgirdwood
singalsu
reviewed
May 31, 2022
Optimize the read/write frags of dcblock processingg functions. By using audio_stream_bytes_without_wrap, this optimization can decrease about 14% MCPS. Signed-off-by: Andrula Song <xiaoyuan.song@intel.com>
singalsu
approved these changes
May 31, 2022
Collaborator
|
I'd expect the MCPS saving from this patch to be larger in current CML, TGL platforms. The penalty from read/write frag API usage was a lot lower in APL and I think GLK is similar with APL. |
lgirdwood
approved these changes
May 31, 2022
cujomalainey
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize the read/write frags of dcblock processingg functions.
By using audio_stream_bytes_without_wrap, this optimization can
decrease about 14% MCPS.
Signed-off-by: Andrula Song xiaoyuan.song@intel.com