topology2: add num_audio_formats for gain #5971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bardliao
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
ranj063
reviewed
Jun 30, 2022
Collaborator
There was a problem hiding this comment.
can you set this in the right pipeline conf file instead then?
Collaborator
Author
There was a problem hiding this comment.
can you set this in the right pipeline conf file instead then?
Indeed, there is no formats defined in gain.conf. So removing it from gain.conf and setting it in pipeline where define available formats makes more sense.
bardliao
force-pushed
the
fixup-add-S24LE-support
branch
from
015f501 to
ae709a2
Compare
ranj063
approved these changes
Jun 30, 2022
bardliao
force-pushed
the
fixup-add-S24LE-support
branch
from
ae709a2 to
8e9bab9
Compare
We should set num_audio_formats in pipelines when we remove the default value from gain.conf. Otherwise, we will see below error with cavs-mixin-mixout-hda-2ch-tgl.tplg tplg: ready widget id 2 pipe 1 type 6 name : gain.1.1 stream none Fixes: 773a05a ('topology2: add S24LE support') Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
bardliao
force-pushed
the
fixup-add-S24LE-support
branch
from
8e9bab9 to
f257b90
Compare
Collaborator
Author
Yes, done |
bardliao
changed the title
ujfalusi
approved these changes
Jul 1, 2022
aiChaoSONG
approved these changes
Jul 1, 2022
lgirdwood
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should set num_audio_formats in pipelines when we remove the
default value from gain.conf.
Otherwise, we will see below error with cavs-mixin-mixout-hda-2ch-tgl.tplg
tplg: ready widget id 2 pipe 1 type 6 name : gain.1.1 stream none
Fixes: 773a05a ('topology2: add S24LE support')