Skip to content

Revert the EQ IIR conversion #6029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
plbossart merged 3 commits into from
Jul 19, 2022
Merged

Revert the EQ IIR conversion #6029

plbossart merged 3 commits into from
Jul 19, 2022

Conversation

@ranj063
Copy link
Collaborator

@ranj063 ranj063 commented Jul 19, 2022 •
edited
Loading

Will be resubmitted after rootcausing the failures

FIxes #6020

ranj063 added 3 commits July 19, 2022 11:17
@ranj063
Revert "module_adapter: Add a new helper to update input/output strea…
bd9dc00 
…m buffers"

This reverts commit ea72e3e.

Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
@ranj063
Revert "audio_format: Add macro for converting bytes <-> samples"
606d5a1 
This reverts commit 2583398.

Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
@ranj063
Revert "eq_iir: Use the new module interface"
494839e 
This reverts commit 9d9ba73.

Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
@fredoh9
Copy link
Contributor

fredoh9 commented Jul 19, 2022

I quickly checked on my ADLP_RVP_NOCODEC, with this revert, it works fine (as expected)

@marc-hb marc-hb mentioned this pull request Jul 19, 2022
Merged
@plbossart
Copy link
Member

plbossart commented Jul 19, 2022

Merging to restore daily-test functionality

@plbossart plbossart merged commit 4af7082 into thesofproject:main Jul 19, 2022
@marc-hb
Copy link
Collaborator

marc-hb commented Jul 19, 2022

FIxes #6020

Not #6022?

@ranj063
Copy link
Collaborator Author

ranj063 commented Jul 19, 2022

FIxes #6020

Not #6022?

yes, probably also #6022

@ranj063 ranj063 deleted the fix/eq_iir_revert branch July 19, 2022 21:34
@marc-hb
Copy link
Collaborator

marc-hb commented Jul 19, 2022

While this reverts seems to help a lot (many more tests passing), there is still a severe firmware crash in:

https://sof-ci.01.org/softestpr/PR930/build98/devicetest?model=ADLP_RVP_NOCODEC&testcase=multiple-pause-resume-5

Disclaimer: I haven't look at the regressions #6020 and #6022 in detail nor any difference between them.

@ranj063
Copy link
Collaborator Author

ranj063 commented Jul 19, 2022

While this reverts seems to help a lot (many more tests passing), there is still a severe firmware crash in:

https://sof-ci.01.org/softestpr/PR930/build98/devicetest?model=ADLP_RVP_NOCODEC&testcase=multiple-pause-resume-5

Disclaimer: I haven't look at the regressions #6020 and #6022 in detail nor any difference between them.

@marc-hb my suspicion is we likely 2 separate regressions. One due to my PR and these ones likely due to something else.

@marc-hb
Copy link
Collaborator

marc-hb commented Jul 19, 2022

And now https://sof-ci.01.org/sofpr/PR6031/build925/devicetest/ is all green... go figure.

This was referenced Jul 20, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@plbossart plbossart plbossart approved these changes

@fredoh9 fredoh9 fredoh9 approved these changes

@marc-hb marc-hb Awaiting requested review from marc-hb

@aborisovich aborisovich Awaiting requested review from aborisovich

@singalsu singalsu Awaiting requested review from singalsu singalsu is a code owner

@lgirdwood lgirdwood Awaiting requested review from lgirdwood lgirdwood is a code owner

@mmaka1 mmaka1 Awaiting requested review from mmaka1 mmaka1 is a code owner

@lbetlej lbetlej Awaiting requested review from lbetlej lbetlej is a code owner

@dbaluta dbaluta Awaiting requested review from dbaluta dbaluta is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] DSP panic when testing signal stop/start on DMIC pipeline

4 participants

@ranj063 @fredoh9 @plbossart @marc-hb