probe-app: add support for non-audio probe buffers #6130
Conversation
kv2019i
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
|
Converting to a draft while debugging a possible bug. |
kv2019i
force-pushed
the
topic/probe-app-nonaudio
branch
2 times, most recently
from
106cacb to
8c305b4
Compare
|
Ready for review. Turns out we also need to add support for non-aligned sync words and payloads. Added this as a separate patch, retested and uploaded. |
|
The checkpatch issues around memcpy and function tab levels, are present in existing code, and I did not want to start refactoring surrounding code in this PR. |
abonislawski
left a comment
abonislawski
left a comment
There was a problem hiding this comment.
Good update to probe-app
tools/probes/probes_main.c
Outdated
There was a problem hiding this comment.
return *((uint32_t *)buf) == PROBE_EXTRACT_SYNC_WORD; or even...
tools/probes/probes_main.c
Outdated
There was a problem hiding this comment.
love C. I guess here both memset(&data...) and memset(data...) would work and mean the same
There was a problem hiding this comment.
@lyakh Well, true, but this isn't really part of my PR. If you change the style, you should change across the file and better done in a separate patch.
tools/probes/probes_main.c
Outdated
There was a problem hiding this comment.
same here - and subjectively fread(data,...) seems clearer to me, but it's just me
|
@lyakh found a bug in finalize wave header function. Turning to draft to block merge until bug is fixed. |
kv2019i
force-pushed
the
topic/probe-app-nonaudio
branch
from
8c305b4 to
e7ab5c1
Compare
Don't assume buffer-id of zero is an invalid value. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Do not blindly call fwrite without checking whether file open succeeded or not. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Modify code to correctly handle probe streams where sync word can occur at any byte boundary, and where probe packet size may not be aligned to 32bit word size. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Identify non-audio probe streams and write them out with ".bin" extension and without the RIFF WAVE header. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
|
Bug found by @lyakh fixed, pushed a new version. Ready for review and merge again. |
6 participants
Series of patches to add non-audio probe buffer support (and few minor fixes).