cmocka: add eq_fir unit test #6308

RanderWang · 2022-09-16T08:56:37Z

This test uses module interface.

Signed-off-by: Rander Wang rander.wang@intel.com

RanderWang · 2022-09-16T09:03:39Z

@singalsu @andrula-song this PR uses pass-through coef. Please help to figure out a non-pass-through coef case. Thanks!

singalsu · 2022-09-16T09:13:22Z

@singalsu @andrula-song this PR uses pass-through coef. Please help to figure out a non-pass-through coef case. Thanks!

Thanks! I will add the Matlab scripts to generate the test vectors for pass-through and some other response shape, e.g. the Loudness EQ in examples for FIR. The the process to create the numbers blobs will be then documented in the scripts.

ranj063 · 2022-09-16T15:40:39Z

@RanderWang we have the infra for unifying the unit tests for modules using the module adapter now. Please have a look at volume for example. Could you please use that as well?

RanderWang · 2022-09-19T01:27:54Z

@RanderWang we have the infra for unifying the unit tests for modules using the module adapter now. Please have a look at volume for example. Could you please use that as well?

Sure, I will. The most important thing for me is to study FIR algorithm and how to make it work. We need to make a usable FIR test first then I can change interface or framework.

singalsu · 2022-09-19T15:34:49Z

test/cmocka/src/audio/eq_fir/cmocka_fir_in.h

Could this be the same input as IIR is using ../../../include/cmocka_chirp_2ch.h ? Not duplicate it here but instead use the same header.

sure. And what's the ref output ? If we uses pass-through coef, this is not a problem

I'm doing a script that exports all needed ref and coef blob files. Then it will be easy to add more tests and change them.

I think the cause of fail with the current error criteria is quantization of FIR coefficients to 16 bit. Need to generate the reference with decoded coefficients from the blob. I'm working on it now.

RanderWang · 2022-09-20T08:54:58Z

Thanks Seppo for helping to make it perfect

lgirdwood · 2022-09-20T21:13:42Z

@RanderWang pls check CI

[ 52%] Building C object test/cmocka/src/audio/eq_fir/CMakeFiles/audio_for_eq_fir.dir/__/__/__/__/__/src/audio/eq_fir/eq_fir.c.o
/home/runner/work/sof/sof/src/audio/eq_fir/eq_fir.c:642:16: error: no previous prototype for ‘sys_comp_eq_fir_init’ [-Werror=missing-prototypes]
  642 | UT_STATIC void sys_comp_eq_fir_init(void)
      |                ^~~~~~~~~~~~~~~~~~~~
[ 53%] Building C object test/cmocka/src/audio/eq_iir/CMakeFiles/audio_for_eq_iir.dir/__/__/__/__/__/src/ipc/ipc-common.c.o
cc1: all warnings being treated as errors
make[2]: *** [test/cmocka/src/audio/eq_fir/CMakeFiles/audio_for_eq_fir.dir/build.make:76: test/cmocka/src/audio/eq_fir/CMakeFiles/audio_for_eq_fir.dir/__/__/__/__/__/src/audio/eq_fir/eq_fir.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1623: test/cmocka/src/audio/eq_fir/CMakeFiles/audio_for_eq_fir.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

marc-hb · 2022-09-20T21:19:50Z

Even more important: check why a cmocka PR fails to compile cmocka in CI but not for you.
If you use cmocka differently from CI then at least one of you is using cmocka wrong.

RanderWang · 2022-09-21T01:05:17Z

@lgirdwood it depends on #6194 and 6194 should be merged first

lgirdwood · 2022-10-03T12:27:24Z

@lgirdwood it depends on #6194 and 6194 should be merged first

Now merged.

RanderWang · 2022-10-10T02:17:34Z

SOFCI TEST

RanderWang · 2022-10-10T07:58:03Z

@softwarecki Unit test is failed for this PR but it passed with ./script/run-cmock.sh locally. I am sure there is no missed change in local environment. Do you know how does CI test unit test ? thanks!

lgirdwood · 2022-10-10T10:36:30Z

@RanderWang see the logs (missing Kconfig option or file in mock build ?)

https://sof-ci.01.org/sof-pr-viewer/#/build/PR6308/build10653042

[ 98%] Linking C executable eq_iir_process
cd /quickbuild/workspace1/24733/SOF_FW/build_ut/test/cmocka/src/audio/eq_iir && /usr/local/bin/cmake -E cmake_link_script CMakeFiles/eq_iir_process.dir/link.txt --verbose=1
/localdisk/tools/xtensa/RG-2017.8-linux/XtensaTools/bin/xt-xcc CMakeFiles/eq_iir_process.dir/eq_iir_process.c.o -o eq_iir_process  ../../../libcommon_mock.a -T/quickbuild/workspace1/24733/SOF_FW/build_ut/test/cmocka/memory_mock.x /localdisk/tools/cmocka/build_cavs2x_LX6HiFi3_2017_8/install/lib/libcmocka-static.a ../../../libcommon_mock.a libaudio_for_eq_iir.a ../../../libcommon_mock.a -lm -lgcc -Wl,--no-check-sections -ucall_user_start -Wl,-static 
make[2]: Leaving directory '/quickbuild/workspace1/24733/SOF_FW/build_ut'
[ 98%] Built target eq_iir_process
[100%] Linking C executable eq_fir_process
cd /quickbuild/workspace1/24733/SOF_FW/build_ut/test/cmocka/src/audio/eq_fir && /usr/local/bin/cmake -E cmake_link_script CMakeFiles/eq_fir_process.dir/link.txt --verbose=1
/localdisk/tools/xtensa/RG-2017.8-linux/XtensaTools/bin/xt-xcc CMakeFiles/eq_fir_process.dir/eq_fir_process.c.o -o eq_fir_process  ../../../libcommon_mock.a -T/quickbuild/workspace1/24733/SOF_FW/build_ut/test/cmocka/memory_mock.x /localdisk/tools/cmocka/build_cavs2x_LX6HiFi3_2017_8/install/lib/libcmocka-static.a ../../../libcommon_mock.a libaudio_for_eq_fir.a ../../../libcommon_mock.a -lm -lgcc -Wl,--no-check-sections -ucall_user_start -Wl,-static 
libaudio_for_eq_fir.a(eq_fir.c.o): In function `eq_fir_free_delaylines':
/quickbuild/workspace1/24733/SOF_FW/src/audio/eq_fir/eq_fir.c:167: undefined reference to `fir_delay_size'
/quickbuild/workspace1/24733/SOF_FW/src/audio/eq_fir/eq_fir.c:167: undefined reference to `fir_init_coef'
/quickbuild/workspace1/24733/SOF_FW/src/audio/eq_fir/eq_fir.c:167: undefined reference to `fir_reset'
libaudio_for_eq_fir.a(eq_fir.c.o): In function `eq_fir_init_coef':
/quickbuild/workspace1/24733/SOF_FW/src/audio/eq_fir/eq_fir.c:203: undefined reference to `fir_delay_size'
/quickbuild/workspace1/24733/SOF_FW/src/audio/eq_fir/eq_fir.c:214: undefined reference to `fir_init_coef'
/quickbuild/workspace1/24733/SOF_FW/src/audio/eq_fir/eq_fir.c:221: undefined reference to `fir_reset'
/quickbuild/workspace1/24733/SOF_FW/src/audio/eq_fir/eq_fir.c:190: undefined reference to `fir_init_delay'
/quickbuild/workspace1/24733/SOF_FW/src/audio/eq_fir/eq_fir.c:194: undefined reference to `fir_init_delay'
libaudio_for_eq_fir.a(eq_fir.c.o): In function `eq_fir_init':
/quickbuild/workspace1/24733/SOF_FW/src/audio/eq_fir/eq_fir.c:315: undefined reference to `fir_reset'
libaudio_for_eq_fir.a(eq_fir.c.o): In function `eq_fir_set_alignment':
/quickbuild/workspace1/24733/SOF_FW/src/include/sof/audio/format.h:170: undefined reference to `eq_fir_2x_s32'
libaudio_for_eq_fir.a(eq_fir.c.o): In function `eq_fir_set_alignment':
/quickbuild/workspace1/24733/SOF_FW/src/include/sof/audio/audio_stream.h:231: undefined reference to `eq_fir_2x_s16'
/quickbuild/workspace1/24733/SOF_FW/src/include/sof/audio/audio_stream.h:234: undefined reference to `eq_fir_2x_s24'
libaudio_for_eq_fir.a(eq_fir.c.o): In function `eq_fir_prepare':
/quickbuild/workspace1/24733/SOF_FW/src/audio/eq_fir/eq_fir.c:111: undefined reference to `fir_reset'
test/cmocka/src/audio/eq_fir/CMakeFiles/eq_fir_process.dir/build.make:102: recipe for target 'test/cmocka/src/audio/eq_fir/eq_fir_process' failed
make[2]: *** [test/cmocka/src/audio/eq_fir/eq_fir_process] Error 2
make[2]: Leaving directory '/quickbuild/workspace1/24733/SOF_FW/build_ut'
CMakeFiles/Makefile2:2625: recipe for target 'test/cmocka/src/audio/eq_fir/CMakeFiles/eq_fir_process.dir/all' failed
make[1]: *** [test/cmocka/src/audio/eq_fir/CMakeFiles/eq_fir_process.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[100%] Linking C executable pipeline_free

RanderWang · 2022-10-10T12:52:43Z

@RanderWang see the logs (missing Kconfig option or file in mock build ?)

[ 98%] Linking C executable eq_iir_process
cd /quickbuild/workspace1/24733/SOF_FW/build_ut/test/cmocka/src/audio/eq_iir && /usr/local/bin/cmake -E cmake_link_script CMakeFiles/eq_iir_process.dir/link.txt --verbose=1
/localdisk/tools/xtensa/RG-2017.8-linux/XtensaTools/bin/xt-xcc CMakeFiles/eq_iir_process.dir/eq_iir_process.c.o -o eq_iir_process  ../../../libcommon_mock.a -T/quickbuild/workspace1/24733/SOF_FW/build_ut/test/cmocka/memory_mock.x /localdisk/tools/cmocka/build_cavs2x_LX6HiFi3_2017_8/install/lib/libcmocka-static.a ../../../libcommon_mock.a libaudio_for_eq_iir.a ../../../libcommon_mock.a -lm -lgcc -Wl,--no-check-sections -ucall_user_start -Wl,-static 
make[2]: Leaving directory '/quickbuild/workspace1/24733/SOF_FW/build_ut'
[ 98%] Built target eq_iir_process
[100%] Linking C executable eq_fir_process
cd /quickbuild/workspace1/24733/SOF_FW/build_ut/test/cmocka/src/audio/eq_fir && /usr/local/bin/cmake -E cmake_link_script CMakeFiles/eq_fir_process.dir/link.txt --verbose=1
/localdisk/tools/xtensa/RG-2017.8-linux/XtensaTools/bin/xt-xcc CMakeFiles/eq_fir_process.dir/eq_fir_process.c.o -o eq_fir_process  ../../../libcommon_mock.a -T/quickbuild/workspace1/24733/SOF_FW/build_ut/test/cmocka/memory_mock.x /localdisk/tools/cmocka/build_cavs2x_LX6HiFi3_2017_8/install/lib/libcmocka-static.a ../../../libcommon_mock.a libaudio_for_eq_fir.a ../../../libcommon_mock.a -lm -lgcc -Wl,--no-check-sections -ucall_user_start -Wl,-static 
libaudio_for_eq_fir.a(eq_fir.c.o): In function `eq_fir_free_delaylines':
/quickbuild/workspace1/24733/SOF_FW/src/audio/eq_fir/eq_fir.c:167: undefined reference to `fir_delay_size'
/quickbuild/workspace1/24733/SOF_FW/src/audio/eq_fir/eq_fir.c:167: undefined reference to `fir_init_coef'
/quickbuild/workspace1/24733/SOF_FW/src/audio/eq_fir/eq_fir.c:167: undefined reference to `fir_reset'
libaudio_for_eq_fir.a(eq_fir.c.o): In function `eq_fir_init_coef':
/quickbuild/workspace1/24733/SOF_FW/src/audio/eq_fir/eq_fir.c:203: undefined reference to `fir_delay_size'
/quickbuild/workspace1/24733/SOF_FW/src/audio/eq_fir/eq_fir.c:214: undefined reference to `fir_init_coef'
/quickbuild/workspace1/24733/SOF_FW/src/audio/eq_fir/eq_fir.c:221: undefined reference to `fir_reset'
/quickbuild/workspace1/24733/SOF_FW/src/audio/eq_fir/eq_fir.c:190: undefined reference to `fir_init_delay'
/quickbuild/workspace1/24733/SOF_FW/src/audio/eq_fir/eq_fir.c:194: undefined reference to `fir_init_delay'
libaudio_for_eq_fir.a(eq_fir.c.o): In function `eq_fir_init':
/quickbuild/workspace1/24733/SOF_FW/src/audio/eq_fir/eq_fir.c:315: undefined reference to `fir_reset'
libaudio_for_eq_fir.a(eq_fir.c.o): In function `eq_fir_set_alignment':
/quickbuild/workspace1/24733/SOF_FW/src/include/sof/audio/format.h:170: undefined reference to `eq_fir_2x_s32'
libaudio_for_eq_fir.a(eq_fir.c.o): In function `eq_fir_set_alignment':
/quickbuild/workspace1/24733/SOF_FW/src/include/sof/audio/audio_stream.h:231: undefined reference to `eq_fir_2x_s16'
/quickbuild/workspace1/24733/SOF_FW/src/include/sof/audio/audio_stream.h:234: undefined reference to `eq_fir_2x_s24'
libaudio_for_eq_fir.a(eq_fir.c.o): In function `eq_fir_prepare':
/quickbuild/workspace1/24733/SOF_FW/src/audio/eq_fir/eq_fir.c:111: undefined reference to `fir_reset'
test/cmocka/src/audio/eq_fir/CMakeFiles/eq_fir_process.dir/build.make:102: recipe for target 'test/cmocka/src/audio/eq_fir/eq_fir_process' failed
make[2]: *** [test/cmocka/src/audio/eq_fir/eq_fir_process] Error 2
make[2]: Leaving directory '/quickbuild/workspace1/24733/SOF_FW/build_ut'
CMakeFiles/Makefile2:2625: recipe for target 'test/cmocka/src/audio/eq_fir/CMakeFiles/eq_fir_process.dir/all' failed
make[1]: *** [test/cmocka/src/audio/eq_fir/CMakeFiles/eq_fir_process.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[100%] Linking C executable pipeline_free

@lgirdwood I can't reproduce it with my environment. All these symbols are included and be built. So I want to know how does CI build it

marc-hb · 2022-10-10T16:54:47Z

A while back I discovered QB uses a "static" version of CMocka:

unit_tests: add workaround for uintptr_t redefinition sof-docs#395 (comment)

Github Actions builds the same commit fine:
https://github.com/thesofproject/sof/actions/runs/3216683629/jobs/5258822444

RanderWang · 2022-10-11T01:52:06Z

A while back I discovered QB uses a "static" version of CMocka:

unit_tests: add workaround for uintptr_t redefinition sof-docs#395 (comment)

Github Actions builds the same commit fine: https://github.com/thesofproject/sof/actions/runs/3216683629/jobs/5258822444

Thanks, Marc, so it is caused by staic version of CMocka ? @kkarask

RanderWang · 2022-10-18T05:47:19Z

SOFCI_TEST

RanderWang · 2022-10-18T07:59:07Z

@lgirdwood the error in unit test is not caused by my PR. please check marc's comment. This PR works with local test. The error is caused by static version of CMocka

Github Actions builds the same commit fine:
https://github.com/thesofproject/sof/actions/runs/3216683629/jobs/5258822444

lgirdwood · 2022-10-19T16:20:42Z

@lgirdwood the error in unit test is not caused by my PR. please check marc's comment. This PR works with local test. The error is caused by static version of CMocka

Github Actions builds the same commit fine: https://github.com/thesofproject/sof/actions/runs/3216683629/jobs/5258822444

Ok, I think we have a GH using x86 cmocka with GCC and internal CI using XCC and xtensa target. @RanderWang can you make the update so XCC cmocka builds work.

marc-hb · 2022-10-19T18:28:07Z

please check marc's comment. This PR works with local test. The error is caused by static version of CMocka

I did not say that. I mentioned one difference I found but the root cause could be something else.

marc-hb · 2022-10-20T17:03:02Z

It looks like the tests are now compiling in https://sof-ci.01.org/sof-pr-viewer/#/build/PR6308/build10629900 but they are not all passing.

RanderWang · 2022-10-24T01:25:32Z

@singalsu now We get a few samples error in only S24_LE test with XCC built FW, no such issue with GCC. The ref = 0x7FFFFF, but FW output = 0xFF800000. @andrula-song will check it. Thanks!

Eq-fir is a process component and use ext_data_length with module adapter. Signed-off-by: Rander Wang <rander.wang@intel.com>

andrula-song · 2022-10-24T03:07:08Z

@singalsu now We get a few samples error in only S24_LE test with XCC built FW, no such issue with GCC. The ref = 0x7FFFFF, but FW output = 0xFF800000. @andrula-song will check it. Thanks!

here is the fix: #6468

lgirdwood · 2022-10-24T11:19:08Z

@RanderWang @andrula-song ping when #6468 is merged.

RanderWang · 2022-10-26T13:38:54Z

SOFCI TEST

lgirdwood · 2022-10-26T13:54:33Z

@RanderWang still some errors in CI UT.
@singalsu @andrula-song @ShriramShastry can you guys help here to advise on how to fix.


56/58 Testing: matrix
56/58 Test: matrix
Command: "/localdisk/tools/xtensa/RG-2017.8-linux/XtensaTools/bin/xt-run" "--exit_with_target_code" "matrix"
Directory: /quickbuild/workspace1/24733/SOF_FW/build_ut/test/cmocka/src/math/matrix
"matrix" start time: Oct 24 13:10 CEST
Output:
----------------------------------------------------------
1..4
Max absolute error =  0.00 (max  1.50), error RMS =  0.00 (max  0.50)
ok 1 - test_matrix_mult_16_test1
Max absolute error =  0.00 (max  1.50), error RMS =  0.00 (max  0.50)
ok 2 - test_matrix_mult_16_test2
Max absolute error =  0.00 (max  1.50), error RMS =  0.00 (max  0.50)
ok 3 - test_matrix_mult_16_test3
Max absolute error =  0.00 (max  1.50), error RMS =  0.00 (max  0.50)
ok 4 - test_matrix_mult_16_test4
# ok - tests
<end of output>
Test time =   5.51 sec
----------------------------------------------------------
Test Passed.
"matrix" end time: Oct 24 13:10 CEST
"matrix" time elapsed: 00:00:05
----------------------------------------------------------

55/58 Testing: window
55/58 Test: window
Command: "/localdisk/tools/xtensa/RG-2017.8-linux/XtensaTools/bin/xt-run" "--exit_with_target_code" "window"
Directory: /quickbuild/workspace1/24733/SOF_FW/build_ut/test/cmocka/src/math/window
"window" start time: Oct 24 13:10 CEST
Output:
----------------------------------------------------------
1..4
Window rectangular RMS error =  0.00 LSB (max  1.00)
ok 1 - test_math_window_rectangular
Window blackman RMS error =  0.67 LSB (max  1.00)
ok 2 - test_math_window_blackman
Window hamming RMS error =  0.00 LSB (max  1.00)
ok 3 - test_math_window_hamming
Window povey RMS error =  0.29 LSB (max  1.00)
ok 4 - test_math_window_povey
# ok - tests
<end of output>
Test time =   6.15 sec
----------------------------------------------------------
Test Passed.
"window" end time: Oct 24 13:10 CEST
"window" time elapsed: 00:00:06
----------------------------------------------------------

57/58 Testing: auditory
57/58 Test: auditory
Command: "/localdisk/tools/xtensa/RG-2017.8-linux/XtensaTools/bin/xt-run" "--exit_with_target_code" "auditory"
Directory: /quickbuild/workspace1/24733/SOF_FW/build_ut/test/cmocka/src/math/auditory
"auditory" start time: Oct 24 13:10 CEST
Output:
----------------------------------------------------------
1..10
Max absolute error =  3.00 (max  5.00), error RMS =  0.91 (max  3.00)
ok 1 - test_mel_filterbank_16_test1
Max absolute error =  3.00 (max  5.00), error RMS =  0.88 (max  3.00)
ok 2 - test_mel_filterbank_32_test1
Max absolute error =  1.00 (max  5.00), error RMS =  0.59 (max  3.00)
ok 3 - test_mel_filterbank_16_test2
Max absolute error =  1.00 (max  5.00), error RMS =  0.47 (max  3.00)
ok 4 - test_mel_filterbank_32_test2
Max absolute error =  1.00 (max  5.00), error RMS =  0.55 (max  3.00)
ok 5 - test_mel_filterbank_16_test3
Max absolute error =  1.00 (max  5.00), error RMS =  0.45 (max  3.00)
ok 6 - test_mel_filterbank_32_test3
Max absolute error =  2.00 (max  5.00), error RMS =  1.04 (max  3.00)
ok 7 - test_mel_filterbank_16_test4
Max absolute error =  2.00 (max  5.00), error RMS =  1.25 (max  3.00)
ok 8 - test_mel_filterbank_32_test4
Max absolute error =  1.00 (max  1.50), error RMS =  0.22 (max  0.50)
ok 9 - test_hz_to_mel
Max absolute error =  3.00 (max  5.00), error RMS =  1.30 (max  1.50)
ok 10 - test_mel_to_hz
# ok - tests
<end of output>
Test time =   6.90 sec
------

RanderWang · 2022-10-26T14:15:21Z

error:
17: not ok 2 - test_audio_eq_fir
17: # 0xffffffffff800000 != 0x7fffff
17: # /quickbuild/workspace1/24733/SOF_FW/test/cmocka/src/audio/eq_fir/eq_fir_process.c:324: error: Failure!

The last error was : The ref = 0x7FFFFF, but FW output = 0xFF800000 before #6468
@singalsu @andrula-song do you have any advice ?

lgirdwood · 2022-10-26T14:56:04Z

error: 17: not ok 2 - test_audio_eq_fir 17: # 0xffffffffff800000 != 0x7fffff 17: # /quickbuild/workspace1/24733/SOF_FW/test/cmocka/src/audio/eq_fir/eq_fir_process.c:324: error: Failure!

Looks like we are comparing a 24bit number to a 64bit number - > do we need a conversion for xt-run or host ?

The last error was : The ref = 0x7FFFFF, but FW output = 0xFF800000 before #6468 @singalsu @andrula-song do you have any advice ?

marc-hb · 2022-10-26T20:56:15Z

SOFCI TEST

Only sof-ci/jenkins knows these magic words and it does not run CMocka. You must force-push. Pro tip: git commit --amend -C HEAD

This test uses module interface for eq_fir. The use of decoded 16 bit FIR blob coefficients decreases a lot the mismatch between float reference FIR vs. SOF fixed point implementation. This patch adds the script tools/tune/eq/cmocka_data_eq_fir.m that generates the files cmocka_fir_coef_2ch.h and cmocka_fir_ref.h. The script debug_files_plot.m can be used to visualize the unit test result and error for data that is generated if macro DEBUG_FILES is defined. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com> Signed-off-by: Andrula Song <xiaoyuan.song@intel.com> Signed-off-by: Rander Wang <rander.wang@intel.com>

RanderWang · 2022-10-27T05:15:27Z

SOFCI TEST

Only sof-ci/jenkins knows these magic words and it does not run CMocka. You must force-push. Pro tip: git commit --amend -C HEAD

Thanks! @lgirdwood pass eq_fir now. need to trigger cmoka test again

RanderWang requested review from aborisovich, dbaluta, lbetlej, lgirdwood, marc-hb, mmaka1 and plbossart as code owners September 16, 2022 08:56

RanderWang mentioned this pull request Sep 16, 2022

eq_fir: use module interface #6194

Merged

RanderWang requested review from andrula-song and singalsu September 16, 2022 09:02

RanderWang force-pushed the unit_eq_fir branch from 2f7eb04 to 09a7f76 Compare September 16, 2022 09:09

singalsu reviewed Sep 19, 2022

View reviewed changes

RanderWang force-pushed the unit_eq_fir branch from 09a7f76 to 7681a4b Compare September 20, 2022 08:53

RanderWang changed the title ~~[RFC] cmocka: add eq_fir unit test~~ cmocka: add eq_fir unit test Sep 20, 2022

singalsu approved these changes Sep 20, 2022

View reviewed changes

lgirdwood approved these changes Sep 20, 2022

View reviewed changes

RanderWang force-pushed the unit_eq_fir branch from 7681a4b to dee5be0 Compare October 10, 2022 03:30

RanderWang force-pushed the unit_eq_fir branch 3 times, most recently from f23d497 to af61070 Compare October 20, 2022 13:17

eq-fir unit test: add ext_data_length for eq-fir

ce65049

Eq-fir is a process component and use ext_data_length with module adapter. Signed-off-by: Rander Wang <rander.wang@intel.com>

RanderWang force-pushed the unit_eq_fir branch from af61070 to 2b314dd Compare October 24, 2022 02:48

lgirdwood mentioned this pull request Oct 24, 2022

Audio: EQ-FIR: fix the shift round bugs #6468

Merged

RanderWang force-pushed the unit_eq_fir branch from 2b314dd to 18227c6 Compare October 27, 2022 01:41

lgirdwood merged commit b97fd67 into thesofproject:main Oct 27, 2022

cmocka: add eq_fir unit test #6308

cmocka: add eq_fir unit test #6308

Uh oh!

Conversation

RanderWang commented Sep 16, 2022

Uh oh!

RanderWang commented Sep 16, 2022

Uh oh!

singalsu commented Sep 16, 2022

Uh oh!

ranj063 commented Sep 16, 2022

Uh oh!

RanderWang commented Sep 19, 2022

Uh oh!

singalsu Sep 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RanderWang Sep 20, 2022

Choose a reason for hiding this comment

Uh oh!

singalsu Sep 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RanderWang commented Sep 20, 2022

Uh oh!

lgirdwood commented Sep 20, 2022

Uh oh!

marc-hb commented Sep 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RanderWang commented Sep 21, 2022

Uh oh!

lgirdwood commented Oct 3, 2022

Uh oh!

RanderWang commented Oct 10, 2022

Uh oh!

RanderWang commented Oct 10, 2022

Uh oh!

lgirdwood commented Oct 10, 2022 • edited by marc-hb Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RanderWang commented Oct 10, 2022

Uh oh!

marc-hb commented Oct 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RanderWang commented Oct 11, 2022

Uh oh!

RanderWang commented Oct 18, 2022

Uh oh!

RanderWang commented Oct 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgirdwood commented Oct 19, 2022

Uh oh!

marc-hb commented Oct 19, 2022

Uh oh!

marc-hb commented Oct 20, 2022

Uh oh!

RanderWang commented Oct 24, 2022

Uh oh!

andrula-song commented Oct 24, 2022

Uh oh!

lgirdwood commented Oct 24, 2022

Uh oh!

RanderWang commented Oct 26, 2022

Uh oh!

lgirdwood commented Oct 26, 2022

Uh oh!

RanderWang commented Oct 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgirdwood commented Oct 26, 2022

Uh oh!

marc-hb commented Oct 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RanderWang commented Oct 27, 2022

singalsu Sep 19, 2022 •

edited

Loading

singalsu Sep 20, 2022 •

edited

Loading

marc-hb commented Sep 20, 2022 •

edited

Loading

lgirdwood commented Oct 10, 2022 •

edited by marc-hb

Loading

marc-hb commented Oct 10, 2022 •

edited

Loading

RanderWang commented Oct 18, 2022 •

edited

Loading

RanderWang commented Oct 26, 2022 •

edited

Loading

marc-hb commented Oct 26, 2022 •

edited

Loading