probe: Add probes logging auto enable option #6364
Conversation
jsarha
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
src/logging/Kconfig
Outdated
There was a problem hiding this comment.
This cant be default y, we can have this feature as optional if you want but in normal flow we need to add probe point to enable logging and kernel must follow this.
There was a problem hiding this comment.
Ok, I removed the "default y". Can you explain why we can not have it? Does Windows driver start to probe extract DMA automatically, or something?
There was a problem hiding this comment.
Because we will try to add probe point to start logging and it will result in error because the same probe point was already added by auto_enable feature.
Please make sure kernel is not assuming it will auto start and send proper request to start logging.
There was a problem hiding this comment.
At the moment kernel is not assuming anything. Its totally agnostic about the probe points and just sends the magic numbers fed to the debugfs file in an to the firmware. At the moment its up to the user to come up with the correct magic numbers to enable the probes it wants, and the number are different in IPC3 and IPC4 modes, that is why I wanted hide the complexity from the user in the simple logging phase.
There was a problem hiding this comment.
This is not our default logging mode so the user should know what he is doing :) But anyway you can hide the complexity from the user but there is no need to change kernel-FW flow, for example you can send probe point magic number request based on simple user trigger/debugfs config or something
There was a problem hiding this comment.
Anyway, there is still three things the user must do for the logs to be coming through probes interface.
- Turn on probes logging back end in fw build
- Turn on probes auto logging in fw build
- Start probes DMA
If someone just likes to user probes for something else and even if we would have the logging back end and the auto logging on by default, it would hardly matter that he gets the logs through probes too. And in any case its easy enough leave the probes logging options out.
But then again I am new here and may not understand everything. Just make a concrete proposal and I change this. So were you suggesting a special debugfs file to turn logs on. @lgirdwood , @ujfalusi , @ranj063 does this sound acceptable? Should I add that to linux driver and drop this PR?
The add config option to automatically enable probes logging when probes extraction dma is started. Signed-off-by: Jyri Sarha <jyri.sarha@intel.com>
jsarha
force-pushed
the
probe-log-autoenable
branch
from
d894341 to
d27b2f9
Compare
@lgirdwood the firmware does not accept any config before the probe dma is started so there is never any configuration when the dma is started (there is no log sysfs). I can of course implement the same functionality in the driver, but it is more complex that way and the driver is exposed the contents for the probe add messages. But yes, its perfectly doable, should I do it that way? From the user point of view the behavior will be the same in either case. |
Why not, would seem reasonable ? |
|
No activity in a long time, converting as draft. |
|
Can one of the admins verify this patch? |
|
There is a more complete version of this PR here: #10096 |
5 participants
The add config option to automatically enable probes logging when probes extraction dma is started.
Signed-off-by: Jyri Sarha jyri.sarha@intel.com