Skip to content

topology2: cavs-nocodec: Add an intermediate pipeline #6401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ranj063 wants to merge 1 commit into from
Closed

topology2: cavs-nocodec: Add an intermediate pipeline #6401

ranj063 wants to merge 1 commit into from

Conversation

@ranj063
Copy link
Collaborator

@ranj063 ranj063 commented Oct 11, 2022

Add an intermediate pipeline between the host and DAI pipelines.

Signed-off-by: Ranjani Sridharan ranjani.sridharan@linux.intel.com

@ranj063 ranj063 mentioned this pull request Oct 11, 2022
Merged
@ranj063
Copy link
Collaborator Author

ranj063 commented Oct 11, 2022

this is how the new tplg looks now.
tplg

plbossart
plbossart approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to test the intermediate pipeline triggers but it should also be updated with the two-stage mixer if and when we figure out what to do with sink_c->sink and source_c->source

@aiChaoSONG
Copy link
Collaborator

aiChaoSONG commented Oct 12, 2022

does the mixout->gain->mixin pipeline have to be present only in playback? I think it is also possible in a capture pipeline.

@ranj063
Copy link
Collaborator Author

ranj063 commented Oct 12, 2022

does the mixout->gain->mixin pipeline have to be present only in playback? I think it is also possible in a capture pipeline.

maybe but I guess for a test for intermediate pipelines, this is good enough

@ranj063
topology2: cavs-nocodec: Add an intermediate pipeline
e45dcf9 
Add an intermediate pipeline between the host and DAI pipelines.

Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
@ranj063 ranj063 force-pushed the fix/intermediate_pipelines branch from 6b96377 to e45dcf9 Compare October 12, 2022 18:42
kv2019i
kv2019i previously requested changes Oct 13, 2022
View reviewed changes
Copy link
Collaborator

@kv2019i kv2019i left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost 100% failure rate in Intel IPC4 plan, see test run 16208 . UPDATE: this can be unrelated as I see FW load failing, but needs to be confirmed.

@miRoox
Copy link

miRoox commented Oct 14, 2022

SOFCI TEST

@aiChaoSONG
Copy link
Collaborator

aiChaoSONG commented Oct 14, 2022

Almost 100% failure rate in Intel IPC4 plan, see test run 16208 . UPDATE: this can be unrelated as I see FW load failing, but needs to be confirmed.

I guess it is because this PR should be tested with the intermediate pipeline kernel support thesofproject/linux#3917

@lgirdwood
Copy link
Member

lgirdwood commented Oct 19, 2022

Almost 100% failure rate in Intel IPC4 plan, see test run 16208 . UPDATE: this can be unrelated as I see FW load failing, but needs to be confirmed.

I guess it is because this PR should be tested with the intermediate pipeline kernel support thesofproject/linux#3917

@aiChaoSONG @kv2019i any update ? Can we merge ?

lgirdwood
lgirdwood approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ranj063 looks like we have a conflict now.

@ranj063
Copy link
Collaborator Author

ranj063 commented Oct 19, 2022

@ranj063 looks like we have a conflict now.

@lgirdwood this will have to wait until we bring back the mixer to the nocodec tplg. We're very close to doing that. Please hold off on merging this for a couple more days

@lgirdwood
Copy link
Member

lgirdwood commented Oct 24, 2022

@ranj063 looks like we have a conflict now.

@lgirdwood this will have to wait until we bring back the mixer to the nocodec tplg. We're very close to doing that. Please hold off on merging this for a couple more days

ok, pls ping me when ready.

@lyakh
Copy link
Collaborator

lyakh commented Oct 26, 2022 •
edited
Loading

how is this related to #6131 ? EDIT: ok, that one is topology1, sorry, ignore this

@plbossart
Copy link
Member

plbossart commented Oct 26, 2022

the goal is the same @lyakh, for both topology1 and 2 we want to catch invalid firmware assumptions that a pipeline is connected to a dai or a host, and in the case of IPC4 detect cases where the intermediate pipeline is not correctly configured by the Linux driver.
Think of the nocodec topology as a 'pipe cleaner'

@kv2019i kv2019i dismissed their stale review October 27, 2022 10:46

We have PR testing for IPC4, so as long as tests pass, I'm fine.

@kv2019i
Copy link
Collaborator

kv2019i commented Feb 17, 2023

@ranj063 array-support merged in #7113 so rebase will be needed

@lyakh
Copy link
Collaborator

lyakh commented Feb 17, 2023

@ranj063 array-support merged in #7113 so rebase will be needed

@kv2019i wouldn't this be dropped in favour of #6981 or do we need both stream types in nocodec?

@ranj063 ranj063 closed this Feb 18, 2023
@ranj063 ranj063 deleted the fix/intermediate_pipelines branch February 18, 2023 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@plbossart plbossart plbossart approved these changes

@lgirdwood lgirdwood lgirdwood approved these changes

@RanderWang RanderWang RanderWang approved these changes

@aiChaoSONG aiChaoSONG aiChaoSONG approved these changes

@kv2019i kv2019i kv2019i left review comments

@mmaka1 mmaka1 Awaiting requested review from mmaka1

@lbetlej lbetlej Awaiting requested review from lbetlej

@dbaluta dbaluta Awaiting requested review from dbaluta

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ranj063 @aiChaoSONG @miRoox @lgirdwood @lyakh @plbossart @kv2019i @RanderWang