component: add frames and period info to component performance profiling #6406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btian1
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
singalsu
approved these changes
Oct 12, 2022
dbaluta
approved these changes
Oct 12, 2022
Collaborator
|
Looks good to me. Minor comment for next patches: please use 'Firstname LastName ' in the signed-off-by tag. |
Contributor
Author
sorry, I changed already, I want first patch perfect. |
kv2019i
approved these changes
Oct 12, 2022
abonislawski
approved these changes
Oct 12, 2022
Frames and period are key information for time calculation, with these and sample rate, it would be easy to get current component consumed data in time domain. CI script also easy to get these information for further calculation. Signed-off-by: Baofeng Tian <baofeng.tian@intel.com>
Collaborator
|
Known failures in Intel IPC4 set, otherwise looks good. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frames and period are key information for time calculation, with these and sample rate, it would be easy to get current component consumed data in time domain. Automatic script also easy to get these information for further calculation.
Signed-off-by: Baofeng Tian baofeng.tian@intel.com