Ipc4 : add ipc4 support in google rtc audio processing #6927

RanderWang · 2023-01-10T09:57:05Z

It will use google rtc audio processing mock config

lgirdwood

@marcinszkudlinski pls review for IPC4

src/audio/google/google_rtc_audio_processing.c

src/ipc/ipc-common.c

RanderWang · 2023-01-12T13:43:42Z

A simple data flow is like this, but this is not the final solution. SSP sends capture data to AEC as reference

lgirdwood · 2023-02-08T11:29:43Z

@perahgren @johnylin76 ping for review.

lgirdwood · 2023-02-09T12:09:15Z

@cujomalainey any comments ?

cujomalainey · 2023-02-10T00:13:09Z

Apologies, that Cavs memory bug has consumed my time this week, will resume reviews next week

kv2019i

Some comments inline.

src/audio/copier/copier.c

src/ipc/ipc-common.c

app/overlays/tgl/ipc4_overlay.conf

RanderWang · 2023-02-13T09:26:06Z

updated to fix buffer cache release issue in copier. Thanks!

cujomalainey · 2023-02-14T20:40:12Z

src/audio/google/google_rtc_audio_processing.c

this seems like generic info no? Is there not a generic struct to use here?

this is a generic info for all AEC modules for SOF IPC4 version

Then it kind of begs the question whether this should be in some more generic header...? Could be that we don't really have a good place for this sort of shared headers that are used by a subset of modules, but worth a check.

@RanderWang ping

@cujomalainey sure, I get it. I will work on it

done! please check it. Thanks!

src/audio/copier/copier.c

src/audio/google/google_rtc_audio_processing.c

kv2019i

Thanks @RanderWang !

kv2019i · 2023-02-16T19:13:03Z

src/audio/google/google_rtc_audio_processing.c

Then it kind of begs the question whether this should be in some more generic header...? Could be that we don't really have a good place for this sort of shared headers that are used by a subset of modules, but worth a check.

ranj063 · 2023-02-16T19:23:33Z

@RanderWang i dont know why you want to add more work for yourself. Please use the module adapter directly when adapting to ipc4

RanderWang · 2023-02-17T01:39:20Z

@RanderWang i dont know why you want to add more work for yourself. Please use the module adapter directly when adapting to ipc4

I get your idea, but I plan to do it step by step. I want to make it merged with simple change first, then add more change.

gkbldcig · 2023-02-18T04:16:59Z

Can one of the admins verify this patch?

lgirdwood · 2023-02-20T10:52:41Z

SOFCI TEST

cujomalainey · 2023-02-21T21:45:22Z

Can one of the admins verify this patch?

Any chance we can get this marked as a bot?

lgirdwood · 2023-02-21T23:34:16Z

Can one of the admins verify this patch?

Any chance we can get this marked as a bot?

I think this may happen when CI loses context due to a reboot @wszypelt @greg-intel @keqiaozhang pls correct me if I'm wrong or provide some context why we see this. Thanks.

lgirdwood · 2023-02-21T23:35:09Z

@RanderWang can you also check the CI result here. Thanks

RanderWang · 2023-02-22T05:14:55Z

@RanderWang can you also check the CI result here. Thanks

@lgirdwood google RTC AEC is not enabled in default build so CI failure is not caused by this PR. Chrome team will has their overlay for chrome like ipc3 and enabled AEC in their overlay file

cujomalainey · 2023-02-22T22:31:17Z

Can one of the admins verify this patch?

Any chance we can get this marked as a bot?

I think this may happen when CI loses context due to a reboot @wszypelt @greg-intel @keqiaozhang pls correct me if I'm wrong or provide some context why we see this. Thanks.

Yes but it should be registered as a bot so it can appear as one

marc-hb · 2023-02-22T23:03:26Z

https://github.com/gkbldcig does not really look "alive"

marc-hb · 2023-02-22T23:14:34Z

google RTC AEC is not enabled in default build so CI failure is not caused by this PR.

Always include the URL because it's lost after a force-push: https://sof-ci.01.org/sofpr/PR6927/build4076/devicetest/index.html

lgirdwood · 2023-02-23T22:22:04Z

@RanderWang can you check again, somethings not right is the code is not used ?

RanderWang · 2023-02-24T02:52:37Z

@RanderWang can you check again, somethings not right is the code is not used ?

@lgirdwood I am %100 confident that this patch can't result to CI failure since (1) we don't add AEC support in topology, so we can't test it (2) we don't enabled GOOGLE_RTC_AEC in config. According to Kai this config should be enabled by chrome overlay config. I also check the building log, no google files are compiled. And my patch only change google file and cmake file

src/audio/google/google_rtc_audio_processing.c

cujomalainey · 2023-02-24T17:36:58Z

https://github.com/gkbldcig does not really look "alive"

neither do some of the accounts that I get follows from e.g. https://github.com/Woodster-cloud

I still think things should be labeled what they are

Add ipc4 config support and hw_params setting Signed-off-by: Rander Wang <rander.wang@intel.com>

Enable dummy AEC building support but still need to enable google AEC in overlay file for chrome. Signed-off-by: Rander Wang <rander.wang@intel.com>

lgirdwood

@cujomalainey good for you ?

RanderWang requested review from aborisovich, bardliao, dbaluta, lbetlej, lgirdwood, marc-hb, marcinszkudlinski, mmaka1 and plbossart as code owners January 10, 2023 09:57

RanderWang force-pushed the ipc4-google-aec branch from 2486bb0 to 71cafa3 Compare January 10, 2023 10:32

RanderWang mentioned this pull request Jan 11, 2023

Ipc4 : add google rtc AEC module support thesofproject/rimage#125

Closed

RanderWang force-pushed the ipc4-google-aec branch from 71cafa3 to 0b17497 Compare January 11, 2023 09:17

lgirdwood reviewed Jan 11, 2023

View reviewed changes

src/audio/google/google_rtc_audio_processing.c Outdated Show resolved Hide resolved

RanderWang force-pushed the ipc4-google-aec branch from 0b17497 to f632eb9 Compare January 12, 2023 01:11

RanderWang requested a review from a team as a code owner January 12, 2023 01:11

lyakh reviewed Jan 12, 2023

View reviewed changes

src/ipc/ipc-common.c Outdated Show resolved Hide resolved

RanderWang force-pushed the ipc4-google-aec branch from f632eb9 to 66416e5 Compare January 12, 2023 13:40

cujomalainey requested review from johnylin76 and perahgren January 12, 2023 19:32

lyakh approved these changes Feb 9, 2023

View reviewed changes

kv2019i requested changes Feb 10, 2023

View reviewed changes

src/audio/copier/copier.c Outdated Show resolved Hide resolved

src/ipc/ipc-common.c Outdated Show resolved Hide resolved

app/overlays/tgl/ipc4_overlay.conf Outdated Show resolved Hide resolved

RanderWang force-pushed the ipc4-google-aec branch from 66416e5 to 0926f42 Compare February 13, 2023 09:24

lgirdwood approved these changes Feb 14, 2023

View reviewed changes

cujomalainey reviewed Feb 14, 2023

View reviewed changes

ujfalusi mentioned this pull request Feb 15, 2023

Fix pipeline source/sink component discovery and smart_amp_test #7099

Merged

RanderWang force-pushed the ipc4-google-aec branch from 0926f42 to c8fb5eb Compare February 16, 2023 01:36

kv2019i approved these changes Feb 16, 2023

View reviewed changes

RanderWang force-pushed the ipc4-google-aec branch from c8fb5eb to 47be951 Compare February 22, 2023 01:37

RanderWang force-pushed the ipc4-google-aec branch from 47be951 to 5361902 Compare February 24, 2023 01:09

lyakh reviewed Feb 24, 2023

View reviewed changes

src/audio/google/google_rtc_audio_processing.c Outdated Show resolved Hide resolved

RanderWang force-pushed the ipc4-google-aec branch from 5361902 to ace3aeb Compare February 24, 2023 09:12

RanderWang force-pushed the ipc4-google-aec branch from ace3aeb to 321aeb2 Compare February 28, 2023 14:13

RanderWang added 2 commits March 1, 2023 16:35

ipc4: google: add ipc4 support for AEC

50953c6

Add ipc4 config support and hw_params setting Signed-off-by: Rander Wang <rander.wang@intel.com>

ipc4: enable google AEC building for zephyr

3b76c12

Enable dummy AEC building support but still need to enable google AEC in overlay file for chrome. Signed-off-by: Rander Wang <rander.wang@intel.com>

RanderWang force-pushed the ipc4-google-aec branch from 321aeb2 to 3b76c12 Compare March 1, 2023 08:36

RanderWang requested a review from pblaszko as a code owner March 1, 2023 08:36

lgirdwood approved these changes Mar 2, 2023

View reviewed changes

cujomalainey approved these changes Mar 2, 2023

View reviewed changes

cujomalainey merged commit 8d5e3a8 into thesofproject:main Mar 2, 2023

RanderWang deleted the ipc4-google-aec branch May 8, 2023 07:11

Ipc4 : add ipc4 support in google rtc audio processing #6927

Ipc4 : add ipc4 support in google rtc audio processing #6927

Uh oh!

Conversation

RanderWang commented Jan 10, 2023

Uh oh!

lgirdwood left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

RanderWang commented Jan 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lgirdwood commented Feb 8, 2023

Uh oh!

lgirdwood commented Feb 9, 2023

Uh oh!

cujomalainey commented Feb 10, 2023

Uh oh!

kv2019i left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RanderWang commented Feb 13, 2023

Uh oh!

cujomalainey Feb 14, 2023

Choose a reason for hiding this comment

Uh oh!

RanderWang Feb 15, 2023

Choose a reason for hiding this comment

Uh oh!

kv2019i Feb 16, 2023

Choose a reason for hiding this comment

Uh oh!

cujomalainey Feb 28, 2023

Choose a reason for hiding this comment

Uh oh!

RanderWang Mar 1, 2023

Choose a reason for hiding this comment

Uh oh!

RanderWang Mar 1, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kv2019i left a comment

Choose a reason for hiding this comment

Uh oh!

kv2019i Feb 16, 2023

Choose a reason for hiding this comment

Uh oh!

ranj063 commented Feb 16, 2023

Uh oh!

RanderWang commented Feb 17, 2023

Uh oh!

gkbldcig commented Feb 18, 2023

Uh oh!

lgirdwood commented Feb 20, 2023

Uh oh!

cujomalainey commented Feb 21, 2023

Uh oh!

lgirdwood commented Feb 21, 2023

Uh oh!

lgirdwood commented Feb 21, 2023

Uh oh!

RanderWang commented Feb 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cujomalainey commented Feb 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marc-hb commented Feb 22, 2023

Uh oh!

marc-hb commented Feb 22, 2023

Uh oh!

lgirdwood commented Feb 23, 2023

RanderWang commented Jan 12, 2023 •

edited

Loading

RanderWang commented Feb 22, 2023 •

edited

Loading

cujomalainey commented Feb 22, 2023 •

edited

Loading

RanderWang commented Feb 24, 2023 •

edited

Loading