scripts/xtensa-build-zephyr.py: checksum [sof_]version.h files #6966
Conversation
`git describe` differences happen, especially when trying to optimize cloning and this is for instance what happened in thesofproject#6950 (comment) where zephyr tags were fetched on Linux but not on Windows This also makes plain git version differences more obvious; no need to scroll all the way up and scan the build logs. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
|
https://github.com/thesofproject/sof/actions/runs/3953435969/jobs/6769706666 shows a https://sof-ci.01.org/sofpr/PR6966/build3436/devicetest/index.html and everything else is green. |
marc-hb
requested review from
dnikodem,
greg-intel,
keqiaozhang,
kv2019i,
lgirdwood,
miRoox and
paulstelian97
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
@aborisovich good for Windows ?
|
While @aborisovich 's review is always desired, this change is 100% OS-independent and the Windows builds in https://github.com/thesofproject/sof/actions/runs/3953435969/jobs/6769706666 show the versions .h files checksummed as expected. |
When using --fw-naming AVS the .ri file is renamed to `dsp_basefw.bin`. Also explain why it's still useful to identify non-deterministic images. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
force-pushed
the
checksum-version-h
branch
from
3363355 to
7014a0e
Compare
Sorry guys, I've been on vacation, returning on Monday :-) |
5 participants
git describedifferences happen, especially when trying to optimize cloning and this is for instance what happened in#6950 (comment) where zephyr tags were fetched on Linux but not on Windows
This also makes plain git version differences more obvious; no need to scroll all the way up and scan the build logs.
Signed-off-by: Marc Herbert marc.herbert@intel.com