Prepare for modules with multiple input/output pins #7014
Conversation
ranj063
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
ranj063
force-pushed
the
fix/audio_formats
branch
from
316e810 to
0d8c831
Compare
There was a problem hiding this comment.
does this belong in this PR? I don't see the link with input/output
There was a problem hiding this comment.
It's a token needed for the pin_index attributes in the new classes
ranj063
force-pushed
the
fix/audio_formats
branch
2 times, most recently
from
15bfbf3 to
c282cef
Compare
|
@ranj063 Care to explain a little bit better what is an output Pin? An output pin is a data line of a DAI? |
@dbaluta this is purely from a module pov. A module could have multiple input and output modules connected to it. The term pin refers to the connection between modules and is used to specify the audio formats required at each end of the connection. |
ranj063
force-pushed
the
fix/audio_formats
branch
from
c282cef to
f104d57
Compare
…mat counts And set them to be the same number as the num_audio_formats in all the current widget objects. This is in preparation to remove num_audio_formats as there will be widgets with different number of supported formats for each sink/source pin. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
ranj063
force-pushed
the
fix/audio_formats
branch
from
f104d57 to
141c546
Compare
…ormats The existing class definition for audio_format works only for widgets with exactly 1 input pin (Pin index 0) and 1 output pin (Pin index 0). Add two new classes that can be used to define the audio formats for any pin. These classes use the same tokens are the existing audio_format class and therefore can be used alongside the existing audio_format instances with non-zero pin indices. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
ranj063
force-pushed
the
fix/audio_formats
branch
from
141c546 to
d4f2db3
Compare
| @@ -0,0 +1,137 @@ | |||
| # Class definition for sink pin audio format object | |||
There was a problem hiding this comment.
I'm confused.
Don't we have support for pins other than index 0? I would thin that they somehow work and somehow they actually get audio format, no?
Isn't the problem lies that we have only one set of audio format definition, which is global for the whole module and for all of it's pins?
There was a problem hiding this comment.
@ujfalusi we dont. The only audio formats we use today are for pin 0 and always intput and output together in pairs. Clearly this wont work
|
One timeout in https://sof-ci.01.org/sofpr/PR7014/build3661/devicetest/index.html , not related to this PR, proceeding with merge. |
7 participants
No description provided.