topology2: use passthrough-capture-be instead of passthrough-be #7091
Conversation
kv2019i
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Add a separate template for capture backend pipelines. The passthrough-be pipeline has been used as template for both playback and capture, but we want to provide different defaults especially for the audio formats in capture case. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
force-pushed
the
202302-tplg-add-capture-be-pipe
branch
from
837ecfd to
232ed97
Compare
| <include/components/copier.conf> | ||
| <include/components/pipeline.conf> | ||
|
|
||
| Class.Pipeline."passthrough-capture-be" { |
There was a problem hiding this comment.
@kv2019i can we call this 32-bit-capture.conf explicitly?
There was a problem hiding this comment.
@ranj063 well, it's not really limited to 32bit, users can add as many audio formats they want, right?
There was a problem hiding this comment.
yeah, lets give users a choice if possible. If not, we can hard code this later.
As the copier can do format conversions, and many pipeline components can do conversions as well, it is important for the topology to define a single format to use in the "dai_out" copier. This ensures deterministic behaviour with the driver. Implement this behaviour by switching topologies to use the passthrough-capture-be pipeline as template for the backend capture pipelines. The previously used passthrough-be template is problematic as the base class already defines multiple audio formats, with multiple different sample formats. The new passthrough-capture-be only defines one sample format by default and is a better starting point as a base class. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
force-pushed
the
202302-tplg-add-capture-be-pipe
branch
from
232ed97 to
855719d
Compare
kv2019i
changed the title
|
V2 (Feb 14):
|
| # All attributes defined herein are namespaced by alsatplg to | ||
| # "Object.Pipeline.passthrough-be-capture.N.attribute_name" | ||
| # | ||
| # Usage: mixin-playback pipeline object can be instantiated as: |
There was a problem hiding this comment.
Oops, copy'n'paste error in the doc, will fix in later version.
There was a problem hiding this comment.
Fix incrementally in another PR.
|
SOFCI TEST Current build results (all green): Previous build results: |
| # All attributes defined herein are namespaced by alsatplg to | ||
| # "Object.Pipeline.passthrough-be-capture.N.attribute_name" | ||
| # | ||
| # Usage: mixin-playback pipeline object can be instantiated as: |
There was a problem hiding this comment.
Fix incrementally in another PR.
| <include/components/copier.conf> | ||
| <include/components/pipeline.conf> | ||
|
|
||
| Class.Pipeline."passthrough-capture-be" { |
There was a problem hiding this comment.
yeah, lets give users a choice if possible. If not, we can hard code this later.
lyakh
left a comment
lyakh
left a comment
There was a problem hiding this comment.
do we actually then need passthrough-be?
Yes, it is used for the playback cases |
5 participants
No description provided.