[stable-v2.5] Backport of fixes #7283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config to get for smart_amp_test module is struct sof_smart_amp_config, instead of the bigger wrapper struct smart_amp_data, so the config size should be the size of struct sof_smart_amp_config. Signed-off-by: Chao Song <chao.song@linux.intel.com> (cherry picked from commit b2ac05f) Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Current code may end up dereferencing null pointers in case memory allocations fail in ams_init(). Handle this with proper error handling. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com> (cherry picked from commit e4dca88)
Volume has multiple data arrays sized to SOF_IPC_MAX_CHANNELS and code that uses these arrays without bounds checks (like volume_ramp()). Add a sanity check to volume_prepare() to ensure channels count is never set to a higher value. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com> (cherry picked from commit e576721)
If the max_block_count attribute is zero, this may lead to division by zero error. Handle this explicitly but reporting error if max_block_count is zero. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com> (cherry picked from commit 82ae105)
This will fix NULL dereference in ipc4_process_chain_dma() Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com> (cherry picked from commit 1319163) Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
dbaluta,
lbetlej,
lgirdwood,
libinyang,
mmaka1 and
plbossart
as code owners
Collaborator
Author
|
Known alsabat fail in https://sof-ci.01.org/sofpr/PR7283/build4673/devicetest/index.html, otherwise CI is clean, proceeding with merge. All patches already reviewed in mainline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set of fixes to issues found via static code analysis.