common.h: Prevent error when compiling with Clang #7411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang requires fields to have a constant size and does not support variable length array in structure causing build to to fail at compile_check() This change selects the compatible version of ALIGN_UP and ALIGN_DOWN macro when compiling with Clang. Signed-off-by: Nishal Kulkarni <nishalkulkarni@gmail.com>
nishalkulkarni
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Collaborator
|
Can one of the admins verify this patch?
|
paulstelian97
approved these changes
Apr 6, 2023
|
Can one of the admins verify this patch? |
lgirdwood
approved these changes
Apr 6, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
test this please |
kv2019i
approved these changes
Apr 10, 2023
Collaborator
|
@wszypelt This one got stuck as well. |
Member
|
@lgirdwood good to merge |
Collaborator
|
Test infra issue in https://sof-ci.01.org/sofpr/PR7411/build5584/devicetest/index.html , not blocking this PR. |
Collaborator
|
Which clang version does this solve a problem with? We've been routinely using |
Collaborator
|
Oh wait, I suspect @dcpleung should this be changed to More background: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang requires fields to have a constant size and does not support variable length array in structure causing build to to fail at compile_check()
This change selects the compatible version of ALIGN_UP and ALIGN_DOWN macro when compiling with Clang.
While there's no official support for LLVM toolchain right now, this change should help in that direction.