[TEST IGNORE] Big sign switch #7595
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-hb
force-pushed
the
big-sign-switch
branch
3 times, most recently
from
7db9be4 to
d050d2c
Compare
Collaborator
Author
|
https://sof-ci.01.org/sofpr/PR7595/build7542/devicetest is all red because it's missing zephyrproject-rtos/zephyr#57820 so the firmware gets signed with the wrong https://sof-ci.01.org/sof-pr-viewer/#/build/PR7595/build11978292 has the usual timeout, hard to tell. |
Collaborator
Author
|
When pointing sof/west.yml at Zephyr PR 57820, IPC4 https://sof-ci.01.org/sofpr/PR7595/build7636/devicetest/index.html is now passing! https://sof-ci.01.org/sofpr/PR7595/build7635/devicetest/index.html is still passing and https://sof-ci.01.org/sof-pr-viewer/#/build/PR7595/build11983340 is green too and the logs show the expected changes. |
This was referenced May 15, 2023
For rimage parameters, parse new, static versions.json file instead of generated sof_versions.h file. This will make possible to configure rimage before west build. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
In some cases it was difficult to separate the command's output from the extra environment it ran in. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Zero functional change, pure clean-up. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This makes no difference now because it has no side-effect yet but it will make a difference once it starts using `west config`. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
We used to use `-- -c rimage/config/platf.toml` for the IPC4 overlay and
the older `--tool-data rimage/config/` for the rest. This was confusing,
inconsistent and used to print this warning:
```
WARNING: --tool-data /var/home/mherber2/SOF/sof/rimage/config ignored,
overridden by: -- -c ...
```
`--tool-data` was always a bad idea. It looks generic but it's not; it
allows changing only a config directory that is always in the same
location.
Copy what `west sign` does with `--tool-data`, drop it and use `-- -c`
always.
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Unlike rimage_configuration(), rimage_options() will be kept free of side-effect. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Zero functional change. This will allow excluding some options. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Do not make the switch yet. Make the switch in a smaller commit that can more easily be reverted in case of a bug or some missed dependency somewhere. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Update Zephyr to commit 6697c5aa0bb296 ("west: sign: rimage: drop
default -c option when the user provides one")
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Stop invoking west sign manually. Configure rimage using `west config` and a platform-specific WEST_CONFIG_LOCAL file instead, then rely on west build to invoke rimage. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Collaborator
Author
|
Superseded by 7684 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.