topology2: cavs-mixin-mixout-hda: Rename mixin-mixout mixers #7641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename mixin and mixout Analog Playback volumes. Rewrite the names of the mixers to better reflect their position in the topology. As a result of this commit mixers are renamed in sof-hda-generic.tplg. 'gain.1.1 1 2nd Playback Volume' becomes 'gain.1.1 Pre Mixer Analog Playback Volume' and 'gain.2.1 2 Main Playback Volume' becomes 'gain.2.1 Post Mixer Analog Playback Volume' Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
This was referenced May 17, 2023
Closed
ranj063
approved these changes
May 18, 2023
ranj063
approved these changes
May 18, 2023
juimonen
approved these changes
May 19, 2023
Collaborator
|
@jsarha can we apply the same pre-mixer/post-mixer convention to all the mixer names in the other topologies as well? Thanks! |
Contributor
Author
Working on it. Just wanted to send this first to know that I am on the right track. On some topologies, nocodec for instance, its not as easy to refer to the related PCM name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename mixin and mixout Analog Playback volumes. Rewrite the names of the mixers to better reflect their position in the topology.
As a result of this commit mixers are renamed in sof-hda-generic.tplg.
'gain.1.1 1 2nd Playback Volume' becomes
'gain.1.1 Pre Mixer Analog Playback Volume'
and
'gain.2.1 2 Main Playback Volume' becomes
'gain.2.1 Post Mixer Analog Playback Volume'