Topo2 fix nocodec capture devices #7694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
added 2 commits
May 26, 2023 13:17
Rename cavs-nocodec capture PCMs. The current PCM names are confusing. These should be better names for them. The former "ssp-capture" is now "Port0 2nd Capture", "DMIC0 Raw" is now "DMIC SFX1", and "DMIC0 Raw 2" is now "DMIC SFX2". The PCMs in question have extra gains in the path to simulate processing. Also the mixer name is changed to compensate for the matching "Capture" substring in the end of the PCM name, that is part of the mixer name, to avoid "Capture Capture" tautology. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
Rename "DMIC" PCM name to "DMIC Raw" in the generic dmic topology fragment. The PCM is on the DMIC patch without any processing beyond gain and IIR EQ, thus the "Raw" extension. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
jsarha
force-pushed
the
topo2_fix_nocodec_capture_devices
branch
from
c2d3525 to
26d3dd4
Compare
4 tasks
|
@jsarha so rebase, as base commit it merged? |
Contributor
Author
Already done. |
juimonen
approved these changes
May 31, 2023
kv2019i
approved these changes
May 31, 2023
| PASSTHROUGH "false" | ||
| SSP0_PCM_NAME "Port0" | ||
| SSP0_CAPTURE_PCM "ssp-capture" | ||
| SSP0_CAPTURE_PCM "Port0 2nd Capture" |
Collaborator
There was a problem hiding this comment.
Why is this "2nd Capture" , I can't immediately figure out... UPDATE: ok, checked the #7093 .
ranj063
approved these changes
Jun 1, 2023
Collaborator
|
Unrelated fails in https://sof-ci.01.org/sofpr/PR7694/build8577/devicetest/index.html and https://sof-ci.01.org/sofpr/PR7694/build8576/devicetest/index.html . Proceeding with merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supposed to fix #7093