xtensa-build-zephyr.py: resolve relative --key arguments #7721
Conversation
Fixes commit a769d39 ("xtensa-build-zephyr.py: stop calling west sign, rely on west build") Before that commit, `xtensa-build-zephyr.py` used to invoke `west sign` directly and in the same current directory. This allowed relative key paths to just work. Now that `west sign` is indirectly invoked by `west build`, there is no possible way to make relative key paths work. So we must resolve them before using them. Fixes thesofproject#7718 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
|
1 suspend/resume timeout in MTL https://sof-ci.01.org/sofpr/PR7721/build8784/devicetest/index.html https://sof-ci.01.org/sof-pr-viewer/#/build/PR7721/build12101750 has a single, totally unrealted failure in Everything else green. |
marc-hb
requested review from
abonislawski,
aiChaoSONG,
fredoh9,
greg-intel,
keqiaozhang,
kv2019i,
paulstelian97 and
softwarecki
|
Good to go, but need to have the mandatory CI checks to pass. |
I spent time looking at all the (rare and isolated) test failures, none is related, see summary above. So there's nothing this PR can do about them. This is a pure build script change. |
We used to provide the `default_rimage_key` in two places: 1) as a default `RIMAGE_KEY` attribute (newer `otc_private_key_3k`) 2) as an explicit `else` clause that was never run because of 1) (older `otc_private_key`) Remove the redundant `else` clause in 2); it became dead code. This simplifies the code and makes the script ready for the day when the key argument will be optional for rimage (more about this in zephyrproject-rtos/zephyr#58356) Signed-off-by: Marc Herbert <marc.herbert@intel.com>
|
I did an empty It's so green that it is actually suspicious so I opened all these links and the logs look fine. |
8 participants
2 commits, please review separately. Main commit:
xtensa-build-zephyr.py: resolve relative --key argumentsFixes commit a769d39 ("xtensa-build-zephyr.py: stop calling west
sign, rely on west build")
Before that commit,
xtensa-build-zephyr.pyused to invokewest signdirectly and in the same current directory. This allowed relative key
paths to just work. Now that
west signis indirectly invoked bywest build, there is no possible way to make relative key paths work. So wemust resolve them before using them.
Fixes #7718