Improve logs on xruns #7736
Closed
Improve logs on xruns #7736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can skip two code blocks that are completely useless when the number of samples is exactly zero, and return earlier. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
A 'nothing to copy' log is not really useful without additional information on when this problem occurred, i.e. if this is on a 1ms tick or after a longer time. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
This is helpful to see when 'dma_copy_bytes' is zero, e.g. [00:01:10.446,761] <inf> host_comp: host_get_copy_bytes_normal: comp:1 0x40002 no bytes to copy, hd->total_data_processed 49664 available samples: 192, free_samples: 0 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart
requested review from
dbaluta,
lbetlej,
lgirdwood and
mmaka1
as code owners
ranj063
approved these changes
Jun 2, 2023
abonislawski
approved these changes
Jun 5, 2023
dnikodem
approved these changes
Jun 5, 2023
softwarecki
approved these changes
Jun 5, 2023
kv2019i
reviewed
Jun 5, 2023
Collaborator
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Not sure about the first change. The glitch warnings have been useful.
| copy_bytes + free_bytes < dd->period_bytes) | ||
| comp_warn(dev, "dai_zephyr_copy(): Copy_bytes %d + free bytes %d < period bytes %d, possible glitch", | ||
| copy_bytes, free_bytes, dd->period_bytes); | ||
|
|
Collaborator
There was a problem hiding this comment.
Hmm, we do skip the glitch detection as well. This has no functional impact, but will affect debugging as the buffer avail/free state is not printed out when we do run out.
| /* return if nothing to copy */ | ||
| if (!samples) { | ||
| comp_warn(dev, "dai_zephyr_copy(): nothing to copy"); | ||
| comp_warn(dev, "dai_zephyr_copy(): nothing to copy, dd->total_data_processed %llu", dd->total_data_processed); |
Collaborator
There was a problem hiding this comment.
Welcome addition. Might be good to add also data on the sink/src_samples status, providing hints whether we are not copying because of pipeline not providing/consuming data, or because of the DAI side. But can be done in later PR.
Contributor
There was a problem hiding this comment.
on the contrary， I would suggest add less characters as possible, if there is an error here, we already get the information, we can add more information personally in local build, add too much debug related code will eventually make 1.9MB exhausted, then have to split out modules as loadable modules, then maybe more bugs will come.
tmleman
approved these changes
Jun 5, 2023
btian1
approved these changes
Jun 15, 2023
lgirdwood
approved these changes
Jul 3, 2023
Member
|
@plbossart Build error on host fuzzer |
Member
Author
|
I can't recall what this 1+ yr old PR was about, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the 'total_data_processed' to the logs to get a better sense of when xruns happen with no space to copy to/from dma buffers, e.g.
The first log is probably ok, this means the DMA has not started yet, but the second one shows the flows are broken with the DMA stuck for a while