Skip to content

ipc3: Don't trust size values in protocol input #7854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andyross wants to merge 1 commit into from
Closed

ipc3: Don't trust size values in protocol input #7854

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/ipc/ipc3/helper.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,10 +277,14 @@ static void comp_specific_builder(struct sof_ipc_comp *comp,
case SOF_COMP_MODULE_ADAPTER:
case SOF_COMP_NONE:
config->process.type = proc->type;
config->process.size = proc->size;
#if CONFIG_LIBRARY || UNIT_TEST
/* FIXME: protocol code paths shouldn't be different for testing */
config->process.size = proc->size;
config->process.data = proc->data + comp->ext_data_length;
#else
/* Clamp size, don't trust the protocol-supplied value! */
config->process.size = MIN(proc->size,
SOF_IPC_MSG_MAX_SIZE - sizeof(*proc));
config->process.data = proc->data;
#endif
break;
Expand Down