volume: Bail out if there is no configuration #7915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsarha
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
btian1
reviewed
Jul 11, 2023
jsarha
force-pushed
the
volume_no_configuration_check
branch
from
8171688 to
3a4a785
Compare
lgirdwood
approved these changes
Jul 11, 2023
cujomalainey
approved these changes
Jul 11, 2023
Contributor
cujomalainey
left a comment
cujomalainey
left a comment
There was a problem hiding this comment.
Actually can you add that cfg->size == sizeof(*vol)?
kv2019i
approved these changes
Jul 12, 2023
Member
|
@jsarha ping, can you adress comment and check CI. Lot of red. Thanks |
It is possible to fabricate a message for FW that initializes volume module without a configuration. Make a safe guard again crashing from that. Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
jsarha
force-pushed
the
volume_no_configuration_check
branch
from
3a4a785 to
432567f
Compare
Contributor
Author
Added. |
lgirdwood
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to fabricate a message for FW that initializes volume module without a configuration. Make a safe guard again crashing from that.
Fixes a similar problem with volume module, as this PR fixes for SRC module: #7830