topology2: fixup google aec topology #7970
Conversation
There was a problem hiding this comment.
With the change, "DMIC0 RTC AEC" has no DAI connected?
There was a problem hiding this comment.
No, please check the pictures
There was a problem hiding this comment.
@RanderWang is top picture "before" and bottom picture "after" this PR ?
There was a problem hiding this comment.
@lgirdwood The bottom picture is generated before this PR which removes the link beween module-copier.18.2 and host-copier.27.capture
There was a problem hiding this comment.
@lgirdwood Yong is enjoying his vocation. @RDharageswari has validated this PR and gave me some feedback.
There was a problem hiding this comment.
i verified this PR.One question on this.
i see the following o/p:
rex-rev1 ~ # arecord -l
**** List of CAPTURE Hardware Devices ****
card 0: sofrt5682 [sof-rt5682], device 0: Headset () []
Subdevices: 1/1
Subdevice #0: subdevice #0
card 0: sofrt5682 [sof-rt5682], device 2: Bluetooth () []
Subdevices: 1/1
Subdevice #0: subdevice #0
card 0: sofrt5682 [sof-rt5682], device 27: DMIC0 RTC AEC () []
Subdevices: 1/1
Subdevice #0: subdevice #0
card 0: sofrt5682 [sof-rt5682], device 28: DMIC0 RTC AEC NS () []
Subdevices: 1/1
Subdevice #0: subdevice #0
card 0: sofrt5682 [sof-rt5682], device 29: EchoRef () []
Subdevices: 1/1
Subdevice #0: subdevice #0
card 0: sofrt5682 [sof-rt5682], device 99: DMIC Raw () []
Subdevices: 1/1
Subdevice #0: subdevice #0
rex-rev1 ~ #
This sequence doesnt work:
1)start speaker playback
2)start dmic capture: arecord -Dhw:0,27 /tmp/tmp.wav -c4 -r48000 -fs32_le -vv
there is a strong dependency on echo reference endpoint to be started.
While this works:
1)start speaker playback
2)start echo ref capture
3)start dmic capture: arecord -Dhw:0,27 /tmp/tmp.wav -c4 -r48000 -fs32_le -vv.
There is no need for the echo reference endpoint to be opened from the user space, while speaker playback the data can be fed to AEC without the FE.Kind of hostless stream.
There was a problem hiding this comment.
@RDharageswari Can you log this as an issue if not already done so. Thanks !
There was a problem hiding this comment.
The first design was to use 3 stream, 2 capture and one playback for speaker. Your requirement is a new feature. We need a loop back module in playback pipeline to dmic pipeline.
There was a problem hiding this comment.
@RDharageswari Can you log this as an issue if not already done so. Thanks !
Sure Liam!
tools/topology/topology2/platform/intel/google-rtc-aec-reference.conf
Outdated
Show resolved
Hide resolved
pin_index is not used so replace it with input_pin_index Signed-off-by: Rander Wang <rander.wang@intel.com>
|
@RDharageswari changes good for you ? |
4 participants
No description provided.