Skip to content

Conversation

@aborisovich
Copy link
Contributor

@aborisovich aborisovich commented Jul 24, 2023

Pull in following rimage changes:
aa0ac9e rimage.c: fix bug where -p requires a new and ignored parameter

Signed-off-by: Andrey Borisovich andrey.borisovich@intel.com

@aborisovich aborisovich force-pushed the update-rimage-revision branch from 441b038 to cd86f30 Compare July 25, 2023 04:41
@aborisovich
Copy link
Contributor Author

aborisovich commented Jul 25, 2023

Any concerns with this PR? Can we merge @lrgirdwo?
Looking at daily SOF CI results, it looks like we have randomly failing test:

check-suspend-resume-50.sh
check-suspend-resume-with-playback-5.sh
check-suspend-resume-with-capture-5.sh
check-suspend-resume-without-audio-20.sh

Bat scope results on Windows CI shows no regression.
This PR is very unlikely to be anyhow related to our current issues...
@marc-hb FYI.

@aborisovich aborisovich requested a review from marc-hb July 25, 2023 15:36
Copy link
Contributor

@btian1 btian1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aborisovich you can try to push again for SOFCI TEST.

@aborisovich aborisovich force-pushed the update-rimage-revision branch from cd86f30 to c6fa097 Compare July 26, 2023 07:51
@marcinszkudlinski
Copy link
Contributor

CI is failing because of #7985
Once is fixed, pls re-run

@lgirdwood
Copy link
Member

SOFCI TEST

@aborisovich aborisovich force-pushed the update-rimage-revision branch from c6fa097 to ff708d8 Compare July 26, 2023 16:19
Pull in following rimage changes:
aa0ac9e rimage.c: fix bug where -p requires a new
and ignored parameter

Signed-off-by: Andrey Borisovich <andrey.borisovich@intel.com>
@aborisovich aborisovich force-pushed the update-rimage-revision branch from ff708d8 to 6d8edf6 Compare July 26, 2023 16:20
@lgirdwood
Copy link
Member

@aborisovich not sure why we would get a build failure in internal CI and not other CIs, can you check. @wszypelt @lrudyX false positive ?

@wszypelt
Copy link

@lgirdwood finally it worked, I'm a little worried that it failed twice on building, but now it's ok

@lgirdwood lgirdwood merged commit e8fdfdd into thesofproject:main Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants