Skip to content

module adapter: avoid module init crash in case of ipc data invalid #7992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kv2019i merged 1 commit into from
Aug 8, 2023
Merged

module adapter: avoid module init crash in case of ipc data invalid #7992

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/audio/module_adapter/module_adapter.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,8 @@ struct comp_dev *module_adapter_new(const struct comp_driver *drv,
goto err;
}
dst->init_data = dst->data;
} else {
Copy link
Collaborator

@ranj063 ranj063 Aug 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@btian1 you still need to explain the change better in the commit message. You're not trying to skip module init, but rather returning an error to not crash in case the IPC data is corrupted for processing modules that have no init data, right?

Copy link
Contributor

@cujomalainey cujomalainey Aug 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is no data a valid part of the spec? If yes then this is invalid

goto err;
}
#else
if (drv->type == SOF_COMP_MODULE_ADAPTER) {
Expand Down