Skip to content

Conversation

@jsarha
Copy link
Contributor

@jsarha jsarha commented Aug 2, 2023

In some error situations the configuration init_data may be NULL, and in such a situations we should fail gracefully and not crash. Also adds check that the IPC message is of correct type and for IPC3 only that it is of correct type.

This is a reincarnation of #7830 that was reverted due to CI problems: #7985

The message type check is now done for IPC3 only.

@dbaluta
Copy link
Collaborator

dbaluta commented Aug 2, 2023

@lgirdwood what Intel platforms are still using IPC3?

What Intel platform completely switched to Zephyr? Do you support IPC3 + Zephyr?

We plan to deprecate XTOS starting with Q4 on i.MX platforms. But we will still be using IPC3 + Zephyr for a while ( I guess)

@jsarha jsarha force-pushed the oss-fuzz-59318-v2 branch from 70b777b to 621279c Compare August 2, 2023 11:38
@jsarha jsarha marked this pull request as ready for review August 2, 2023 11:38
@lgirdwood
Copy link
Member

@lgirdwood what Intel platforms are still using IPC3?

None on main. Only older platforms using stable-v2.2 branch for fixes only.

What Intel platform completely switched to Zephyr? Do you support IPC3 + Zephyr?

We plan to deprecate XTOS starting with Q4 on i.MX platforms. But we will still be using IPC3 + Zephyr for a while ( I guess)

All Intel platforms on main. i.e. everything from Tigerlake onwards. All older platforms are on stable v2.2 branch with xtos + IPC3.

In some error situations the configuration init_data may be NULL, and
in such a situations we should fail gracefully and not crash. Also adds
check that the IPC message is of correct type and for IPC3 only that it
is of correct type.

Signed-off-by: Jyri Sarha <jyri.sarha@linux.intel.com>
@jsarha jsarha force-pushed the oss-fuzz-59318-v2 branch from 621279c to c78efeb Compare August 4, 2023 15:01
@kv2019i
Copy link
Collaborator

kv2019i commented Aug 7, 2023

SOFCI TEST

@kv2019i
Copy link
Collaborator

kv2019i commented Aug 7, 2023

Looks ready to go, just needs a clean CI run to merge.

@kv2019i kv2019i merged commit 681135c into thesofproject:main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants