Skip to content

Conversation

@marcinszkudlinski
Copy link
Contributor

Rate for sink was not set properly in src.c

Rate for sink was not set properly in src.c

Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
@singalsu
Copy link
Collaborator

Thanks, to be sure I'll give this a try with #7547 . We don't have in CI test for this.

Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll wait @singalsu for your ack on this.

@singalsu
Copy link
Collaborator

Unfortunately this is not fixing the regression that has happened. @marcinszkudlinski Is there a bug that you see that this fixes?

Probably OK to merge this but some other fixes are needed too.

@singalsu
Copy link
Collaborator

singalsu commented Aug 15, 2023

I wonder if every component should set both source and sink params from init IPC? E.g. Aria sets both in

source = list_first_item(&dev->bsource_list, struct comp_buffer, sink_list);

What is the recommendation for IPC4 modules @marcinszkudlinski ?

I'm getting with this patch a divide by zero exception in source_get_data_frames_available(). Apparently source_get_frame_bytes(source) returns zero. Doing "arecord -Dhw:0,2 -f dat -r 44100 -d 10 rec.wav" with topology from #7547.

I think the exception happens also without this patch but it was the 1st time able was able to catch it to trace.

@lgirdwood
Copy link
Member

@wszypelt @lrudyX not expecting this to fail unless CI is making a different assumption to SRC for rates ?

@lrudyX
Copy link

lrudyX commented Aug 16, 2023

@wszypelt @lrudyX not expecting this to fail unless CI is making a different assumption to SRC for rates ?

We have fail with LNL. Fails only with this platform.

@lgirdwood
Copy link
Member

SOFCI TEST

@lgirdwood
Copy link
Member

@marcinszkudlinski rerunning CI to rule out a false positive result.

@kv2019i
Copy link
Collaborator

kv2019i commented Aug 21, 2023

Proceeding with merge, only known fails in CI report.

@kv2019i kv2019i merged commit b036086 into thesofproject:main Aug 21, 2023
@marcinszkudlinski marcinszkudlinski deleted the src_sink_rate branch September 18, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants