-
Notifications
You must be signed in to change notification settings - Fork 349
src: bugfix: rate for sink not set #8032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rate for sink was not set properly in src.c Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
|
Thanks, to be sure I'll give this a try with #7547 . We don't have in CI test for this. |
kv2019i
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'll wait @singalsu for your ack on this.
|
Unfortunately this is not fixing the regression that has happened. @marcinszkudlinski Is there a bug that you see that this fixes? Probably OK to merge this but some other fixes are needed too. |
|
I wonder if every component should set both source and sink params from init IPC? E.g. Aria sets both in Line 182 in 8f60180
What is the recommendation for IPC4 modules @marcinszkudlinski ? I'm getting with this patch a divide by zero exception in source_get_data_frames_available(). Apparently source_get_frame_bytes(source) returns zero. Doing "arecord -Dhw:0,2 -f dat -r 44100 -d 10 rec.wav" with topology from #7547. I think the exception happens also without this patch but it was the 1st time able was able to catch it to trace. |
|
SOFCI TEST |
|
@marcinszkudlinski rerunning CI to rule out a false positive result. |
|
Proceeding with merge, only known fails in CI report. |
Rate for sink was not set properly in src.c