Audio: Crossover: Misc fixes #8088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check needs to be for or, the and condition is never met. With e.g. num_sinks = 1 the index to function map became -1 that returned an invalid function. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
The issue with __sparse_cache in sinks[] array seems quite complicated to change so avoiding it with further module API conversion seems like better approach. The processing functions in crossover_generic.c are changed to use struct output_stream_buffer pointer array from module API. The function crossover_assign_sinks() is changed to pick the output stream buffers from module API in the order that is defined in configuration blob. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
requested review from
a team,
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
lgirdwood
approved these changes
Aug 24, 2023
cujomalainey
approved these changes
Aug 24, 2023
Contributor
|
Sparse errors are for unrelated files. Intel CI appears down. This isn't part of the main build anyways so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.