Add 24bit msb support #8151
Merged
Add 24bit msb support #8151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is missed in kconfig. Signed-off-by: Rander Wang <rander.wang@intel.com>
For sample format with 24 bits valid sample bit and 32 bits container, valid sample is at msb 24bits if IPC4_TYPE_MSB_INTEGER is set. Signed-off-by: Rander Wang <rander.wang@intel.com>
Remove gateway type and direction for pcm conversion check and will move them to copier module. This will make pcm conversion check more general and simple. Also remove s16/c32 for gateway since it is never used. Signed-off-by: Rander Wang <rander.wang@intel.com>
At first the sample type is set to MSB_INTEGER to follow windows settings, but actually we use LSB_INTERGER type such as S24_4LE. Now change the default sample type to LSB_INTERGER to align with FW usage. For DAI copier we need to use MSB_INTERGER for hardware requirement. Currently sample type only affect s24/c32 case, so only change sample type in dai for this format config. FW will use sample type to choose correct format conversion function and can deal with Windows audio stream correctly with MSB s24/c32 format. out_fmt_cfg is redefined for a alsa-lib bug. Alsa-lib will first process out_fmt_cfg = '$[($out_channels | ($out_valid_bit_depth * 256)) | ($out_sample_type * 65536)]' in base class and then deal with out_sample_type, so error is reported. Now first define out_sample_type and then out_fmt_cfg, everything works. Signed-off-by: Rander Wang <rander.wang@intel.com>
Adjust valid format in copier for some types of dai gateway which need to use MSB type. Currently sample type only affect the copier module so we don't do it in audio_stream_fmt_conversion. Signed-off-by: Rander Wang <rander.wang@intel.com>
RanderWang
requested review from
a team,
abonislawski,
dbaluta,
jsarha,
kv2019i,
lbetlej,
lgirdwood,
marcinszkudlinski,
mmaka1,
pblaszko,
plbossart and
ranj063
as code owners
kv2019i
approved these changes
Sep 5, 2023
Collaborator
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Thanks @RanderWang , let's see the CI results.
Collaborator
|
One system-PM fail in https://sof-ci.01.org/sofpr/PR8151/build12561/devicetest/index.html , rest is good. Sparse fail in https://github.com/thesofproject/sof/actions/runs/6080655526/job/16494931901?pr=8151 and will be fixed in #8147 Waiting for further reviews, we can then merge. |
btian1
approved these changes
Sep 6, 2023
Contributor
btian1
left a comment
btian1
left a comment
There was a problem hiding this comment.
please fix code style issue.
Collaborator
|
The checkpatch is about Kconfig documentation and this patch matches the other entries, so we can let this go. Given this was already reviewed in #7959 , I'm proceeding to merge this so we can get this into 2.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch was merged by #7959 but revert by #8089 for a internal CI issue. Now the CI issue has been resovled so add it again. please check issue #8086 for detail