zephyr: fix issues with init.h include #8154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Module is using Zephyr SYS_INIT API, defined in init.h, not device.h. Code relied on indirect includes. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
Because module uses SYS_INIT defined in init.h. Things likely worked because of indirect includes. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
Collaborator
|
Can one of the admins verify this patch?
|
dabekjakub
approved these changes
Sep 5, 2023
kv2019i
approved these changes
Sep 5, 2023
lyakh
approved these changes
Sep 5, 2023
Collaborator
|
Thanks! Sparse error in https://github.com/thesofproject/sof/actions/runs/6082149977/job/16499306627?pr=8154 is known and should be fixed by #8147 I don't know what happened to sof-ci/jenkins, trying to re-run it. 
|
Collaborator
|
SOFCI TEST EDIT: sof-ci/jenkins tests are running now, no idea what happened 5 hours ago. |
btian1
approved these changes
Sep 6, 2023
Collaborator
|
test this please |
Collaborator
|
@wszypelt This seems to got stuck, can you check? |
|
@kv2019i Sure thing, the PR is already in the queue to be done, I think the results will be in an hour |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.