Skip to content

topology2: merge multi-core test into nocodec topology #8240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kv2019i merged 1 commit into from
Nov 10, 2023
Merged

topology2: merge multi-core test into nocodec topology #8240

kv2019i merged 1 commit into from
Nov 10, 2023

Conversation

@RanderWang
Copy link
Collaborator

@RanderWang RanderWang commented Sep 21, 2023 •
edited
Loading

The multi-core topology was created since multi-core feature had a few bugs at that time so it was for validation test. Now this feature works fine so merge it into nocodec topology then it will be tested by github CI. And we don't need to maintain a dedicated multi-core topology.
Screenshot from 2023-09-21 16-00-45

ranj063
ranj063 reviewed Sep 21, 2023
View reviewed changes
tools/topology/topology2/cavs-nocodec.conf Outdated
{
index 6
direction playback
core_id $SSP2_PCM_CORE_ID
Copy link
Collaborator

@ranj063 ranj063 Sep 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RanderWang the suggested change is fine for the regular nocodec topology. But for the passthrough nocodec topology, I'd suggest to keep all core IDs as 0. @plbossart what do you think?

Copy link
Collaborator Author

@RanderWang RanderWang Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I can image it. Removed.

@lgirdwood
Copy link
Member

lgirdwood commented Sep 25, 2023

@RanderWang conflicts.

@RanderWang
Copy link
Collaborator Author

RanderWang commented Sep 26, 2023

rebased, thanks

@lgirdwood
Copy link
Member

lgirdwood commented Sep 26, 2023

@RanderWang are we still expecting some rough edges ?

2023-09-26 03:18:58 UTC [ERROR] Caught kernel log error
===========================>>
[  317.740853] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: FW reported error: 6 - Unknown error while processing the request
[  317.741220] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: ipc error for msg 0x47000000|0x0
[  317.741236] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: error: failed to disable target core: 2 for widget pipeline.6
[  317.741249] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: Failed to free connected widgets
[  317.741276] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: ASoC: error at snd_soc_pcm_component_hw_free on 0000:00:1f.3: -22

@RanderWang
Copy link
Collaborator Author

RanderWang commented Sep 27, 2023

@RanderWang are we still expecting some rough edges ?

2023-09-26 03:18:58 UTC [ERROR] Caught kernel log error
===========================>>
[  317.740853] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: FW reported error: 6 - Unknown error while processing the request
[  317.741220] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: ipc error for msg 0x47000000|0x0
[  317.741236] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: error: failed to disable target core: 2 for widget pipeline.6
[  317.741249] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: Failed to free connected widgets
[  317.741276] kernel: sof-audio-pci-intel-tgl 0000:00:1f.3: ASoC: error at snd_soc_pcm_component_hw_free on 0000:00:1f.3: -22

We have a [BUG] [v2.7-rc1] IPC timed out for 0x47000000|MOD_SET_DX when suspending on ADLP_RVP_NOCODEC #8072. I will check this issue later since it has low priority

@kv2019i
Copy link
Collaborator

kv2019i commented Oct 2, 2023

@RanderWang #8072 has low priority only because we haven't seen it in a long time (i.e. observed reproduction rate is low). The cases with this PR also look different. 8072 is an IPC timeout, but here we see IPC error response "FW reported error: 4 - The system or resource is busy".

@kv2019i
Copy link
Collaborator

kv2019i commented Oct 18, 2023

ping @RanderWang ?

@RanderWang
Copy link
Collaborator Author

RanderWang commented Oct 19, 2023

@kv2019i We get some issues with cavs platforms and I am debugging it

@RanderWang RanderWang force-pushed the multi-core-merge branch 2 times, most recently from 4fccb54 to 432dbba Compare October 23, 2023 05:39
@lgirdwood
Copy link
Member

lgirdwood commented Oct 23, 2023

@kv2019i We get some issues with cavs platforms and I am debugging it

Does the newest update resolve issues ?

@RanderWang
Copy link
Collaborator Author

RanderWang commented Oct 24, 2023

@kv2019i We get some issues with cavs platforms and I am debugging it

Does the newest update resolve issues ?

I just rebased the code. It is a fw bug and I am still debugging it

@RanderWang
Copy link
Collaborator Author

RanderWang commented Oct 25, 2023

SOFCI TEST

@lgirdwood
Copy link
Member

lgirdwood commented Oct 25, 2023

@kv2019i We get some issues with cavs platforms and I am debugging it

Does the newest update resolve issues ?

I just rebased the code. It is a fw bug and I am still debugging it

Does the latest update resolve the issue ?

lyakh
lyakh reviewed Oct 26, 2023
View reviewed changes
zephyr/lib/pm_runtime.c Outdated
DECLARE_TR_CTX(power_tr, SOF_UUID(power_uuid), LOG_LEVEL_INFO);

#if defined(CONFIG_PM_POLICY_CUSTOM)
struct pm_state_info default_pm_state = {PM_STATE_ACTIVE, 0, 0};
Copy link
Collaborator

@lyakh lyakh Oct 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const static

This was referenced Oct 26, 2023
Merged
Merged
@RanderWang RanderWang mentioned this pull request Nov 6, 2023
Merged
@lgirdwood lgirdwood added this to the v2.8 milestone Nov 8, 2023
@RanderWang
topology2: merge multi-core test into nocodec topology
b22a4d4 
The multi-core topology was created since multi-core feature had a few
bugs at that time so it was for validation test. Now this feature works
fine so merge it into nocodec topology then it will be tested by
github CI. And we don't need to maintain a dedicated multi-core topology.

Signed-off-by: Rander Wang <rander.wang@intel.com>
@kv2019i
Copy link
Collaborator

kv2019i commented Nov 10, 2023

Only single system PM fail now in https://sof-ci.01.org/sofpr/PR8240/build14811/devicetest/index.html , looks good to go.

@kv2019i kv2019i merged commit 547132b into thesofproject:main Nov 10, 2023
@fredoh9 fredoh9 mentioned this pull request Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lyakh lyakh lyakh left review comments

@ranj063 ranj063 ranj063 approved these changes

@lgirdwood lgirdwood lgirdwood approved these changes

@jsarha jsarha Awaiting requested review from jsarha jsarha is a code owner

@keqiaozhang keqiaozhang Awaiting requested review from keqiaozhang

@kv2019i kv2019i Awaiting requested review from kv2019i

@mengdonglin mengdonglin Awaiting requested review from mengdonglin

@iuliana-prodan iuliana-prodan Awaiting requested review from iuliana-prodan

@dbaluta dbaluta Awaiting requested review from dbaluta

@abonislawski abonislawski Awaiting requested review from abonislawski

@tmleman tmleman Awaiting requested review from tmleman

@plbossart plbossart Awaiting requested review from plbossart

@mmaka1 mmaka1 Awaiting requested review from mmaka1

@lbetlej lbetlej Awaiting requested review from lbetlej

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2.8

Development

Successfully merging this pull request may close these issues.

5 participants

@RanderWang @lgirdwood @kv2019i @lyakh @ranj063