Tools: Topology2: Remove 50 ms curve duration set from nocodec #8242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to care about audio user experience and peak MCPS usage in production topologies. The alsabat test is disturbed by the longer ramp so the change can be reverted from nocodec topologies. Those topologies are never used by end users. Also the peak MCPS mitigation is not relevant for test topologies, as long as higher MCPS is not triggering error reports. The curve duration is restored without explicit set to the default 20 ms. Fixes: thesofproject#8238 Fixes: d0d74a4 ("Tools: Topology2: Change in capture gain curve_duration to 50 m") Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
tplg2_nocodec_restore_20ms_curve_duration
branch
from
b4dc316 to
2f163ad
Compare
Collaborator
Author
No, it's not fully reverting the patch. Only the nocodec topologies those are tested in CI are changed back. And really need to start to develop fix for alsabat. We can't continue changing default behavior to follow shortcomings of test tool. |
kv2019i
approved these changes
Sep 25, 2023
lgirdwood
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to care about audio user experience and peak MCPS usage in production topologies.
The alsabat test is disturbed by longer ramp so it can be removed from nocodec topologies since the codec is never used by end users and also the peak MCPS mitigation is not relevant for a test topology, as long as higher MCPS is not triggering error reports. The curve duration becomes without explicit set the default 20 ms.
Fixes: #8238
Fixes: d0d74a4
("Tools: Topology2: Change in capture gain
curve_duration to 50 m")