Revert "module_adapter: avoid module init crash in case of ipc data invalid" #8303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btian1
reviewed
Oct 11, 2023
| dst->init_data = dst->data; | ||
| } else if (size == 0) { | ||
| /* valid case for mixer */ | ||
| return 0; |
Contributor
There was a problem hiding this comment.
if this is the case, do we still need keep line 85 - 87?
Collaborator
Contributor
Author
There was a problem hiding this comment.
kv2019i
reviewed
Oct 11, 2023
Collaborator
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
I'd suggest a revert and then do a follow-up to make a new fix to avoiding module init crashes (if a generic module level solution is possible, not sure it is).
| dst->init_data = dst->data; | ||
| } else if (size == 0) { | ||
| /* valid case for mixer */ | ||
| return 0; |
Collaborator
…nvalid" This reverts 'commit e847c8b ("module_adapter: avoid module init crash in case of ipc data invalid")'. No data is not an invalid case for mixer, for example. Fixes: thesofproject#8265 Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com>
iuliana-prodan
force-pushed
the
mixer_tplg_load
branch
from
0264032 to
22d9e9c
Compare
iuliana-prodan
changed the title
dbaluta
approved these changes
Oct 12, 2023
btian1
approved these changes
Oct 13, 2023
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "module_adapter: avoid module init crash in case of ipc data invalid"
This reverts 'commit e847c8b ("module_adapter: avoid module
init crash in case of ipc data invalid")'.
No data is not an invalid case for mixer, for example.
Fixes: #8265
Signed-off-by: Iuliana Prodan iuliana.prodan@nxp.com