Skip to content

zephyr: remove stray } from RIMAGE_CONFIG_PATH #8307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kv2019i merged 1 commit into from
Oct 11, 2023
Merged

zephyr: remove stray } from RIMAGE_CONFIG_PATH #8307

kv2019i merged 1 commit into from
Oct 11, 2023

Conversation

@nashif
Copy link
Contributor

@nashif nashif commented Oct 11, 2023

A stray } is at the end of RIMAGE_CONFIG_PATH causing issues when
signing images.

Signed-off-by: Anas Nashif anas.nashif@intel.com

@nashif
zephyr: remove stray } from RIMAGE_CONFIG_PATH
03b8644 
A stray } is at the end of RIMAGE_CONFIG_PATH causing issues when
signing images.

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
@nashif nashif requested a review from marc-hb as a code owner October 11, 2023 12:09
@nashif nashif requested review from kv2019i and lgirdwood October 11, 2023 12:10
kv2019i
kv2019i approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea how this worked in our CI. Thanks @nashif !

marc-hb
marc-hb approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nashif ! This wasn't caught because

  • we override RIMAGE_CONFIG_PATH, that default value is ignored in our build script
  • this did not cause any CMake syntax error! It merely added garbage at the end of value.

@kv2019i kv2019i merged commit 5b5566f into thesofproject:main Oct 11, 2023
@marc-hb
Copy link
Collaborator

marc-hb commented Oct 11, 2023

https://sof-ci.01.org/sofpr/PR8307/build13821/devicetest/index.html failed to load the firmware with

Oct 11 12:21:43 sh-mtlp-rvp-hda-03 kernel: skl_hda_dsp_generic skl_hda_dsp_generic: ASoC: Failed to add route iDisp3 Tx -> hifi3(*)
Oct 11 12:21:43 sh-mtlp-rvp-hda-03 kernel: skl_hda_dsp_generic skl_hda_dsp_generic: ASoC: Failed to add route iDisp2 Tx -> hifi2(*)
Oct 11 12:21:43 sh-mtlp-rvp-hda-03 kernel: skl_hda_dsp_generic skl_hda_dsp_generic: ASoC: Failed to add route iDisp1 Tx -> hifi1(*)
Oct 11 12:21:43 sh-mtlp-rvp-hda-03 kernel: skl_hda_dsp_generic skl_hda_dsp_generic: snd_soc_bind_card: snd_soc_dapm_add_routes failed: -19

Already seen in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kv2019i kv2019i kv2019i approved these changes

@marc-hb marc-hb marc-hb approved these changes

@lgirdwood lgirdwood Awaiting requested review from lgirdwood

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nashif @marc-hb @kv2019i