topology2: add cs42l43 + cs35l56 topology for MTL and TGL #8359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kv2019i
reviewed
Oct 20, 2023
lgirdwood
approved these changes
Oct 20, 2023
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
@RanderWang @ranj063 @jsarha in general we need to make sure we add more comments in our topologies like we do with our C cide, especially around any conditional logic.
bardliao
force-pushed
the
sof-tgl-cs42l43-l3-cs35l56-l01
branch
from
70b9412 to
e93e3e4
Compare
Member
kv2019i
approved these changes
Nov 13, 2023
kv2019i
requested changes
Nov 13, 2023
Collaborator
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Change of mind, see inline.
kv2019i
reviewed
Nov 13, 2023
RanderWang
approved these changes
Nov 14, 2023
MSB_INTEGER is required for ALH copier. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
To indicate the SoundWire amp need to use 24 bit format. I use a flag instead of a macro like $SDW_AMP_FMT to set valid_bit_depth because bit_depth and valid_bit_depth may not be the same. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Use tab instead of space. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
To indicate the SoundWire jack need to use 24 bit format. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
bardliao
force-pushed
the
sof-tgl-cs42l43-l3-cs35l56-l01
branch
from
e93e3e4 to
331639d
Compare
Add topology2 support for cs42l43 + cs35l56. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Add cs42l43 + cs35l56 topology for MTL. Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
bardliao
force-pushed
the
sof-tgl-cs42l43-l3-cs35l56-l01
branch
from
331639d to
a644197
Compare
Collaborator
|
@ranj063 @plbossart Final call on this soon... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
topology2: add cs42l43 + cs35l56 topology for MTL and TGL