base_fw: add DMI_FORCE_L1_EXIT FW config (depends on Zephyr 66042) #8561
Conversation
fkwasowi
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
kv2019i
changed the title
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Thanks, SOF side looks good, but Zephyr side PR needs to pass and be merged first.
fkwasowi
force-pushed
the
prv-fkwasowi_l1_exit_ipc
branch
2 times, most recently
from
5c3955d to
25866d9
Compare
fkwasowi
force-pushed
the
prv-fkwasowi_l1_exit_ipc
branch
2 times, most recently
from
2ebbfb3 to
8d311ef
Compare
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
I'm afraid we have multiple build errors for "lnl" and "tgl". We need a fixup to Zephyr upstream, it seems the L1_EXIT define is not available for lnl and for "tgl" inclusion of adsp_shim.h is causing problems.
fkwasowi
force-pushed
the
prv-fkwasowi_l1_exit_ipc
branch
from
8d311ef to
103910e
Compare
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Zephyr PR is now good and lnl compiles but still some issues on the SOF side changes, please see inline (and CI results).
fkwasowi
force-pushed
the
prv-fkwasowi_l1_exit_ipc
branch
2 times, most recently
from
3b52b65 to
f10fb9c
Compare
fkwasowi
requested review from
cujomalainey,
jxstelter,
marc-hb and
ranj063
as code owners
fkwasowi
requested review from
RanderWang,
marcinszkudlinski and
pblaszko
as code owners
intel_adsp: lnl: add missing definition for lnl 28d5d23a232b69b213112e723e0a6392cbd5a47e Signed-off-by: Fabiola Kwasowiec <fabiola.kwasowiec@intel.com>
fkwasowi
force-pushed
the
prv-fkwasowi_l1_exit_ipc
branch
from
e3742d3 to
f34fc81
Compare
|
@fkwasowi The tgl/tgl-h still seems to fail, can you check: |
fkwasowi
force-pushed
the
prv-fkwasowi_l1_exit_ipc
branch
from
f34fc81 to
1fca404
Compare
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Code looks good now. One suggestion about how to handle platforms that do not support this feature. I wonder if return an error would be more future-proof, but this is not blocking issue to me.
src/audio/base_fw.c
Outdated
|
|
||
| if (force) { | ||
| tr_info(&basefw_comp_tr, "FW config set force dmi l0 state"); | ||
| #if defined(CONFIG_SOC_SERIES_INTEL_ACE) |
There was a problem hiding this comment.
Not sure what to return if the functionality is not available. Alternatively you could #ifdef the whole funciton body and at the end:
#if defined(CONFIG_SOC_SERIES_INTEL_ACE)
const uint32_t force = ..
...
#else
return IPC4_UNAVAILABLE;
#endif
Add new parameter for SW to force DMI L1 exit on IPC request. Signed-off-by: Fabiola Kwasowiec <fabiola.kwasowiec@intel.com>
fkwasowi
force-pushed
the
prv-fkwasowi_l1_exit_ipc
branch
from
1fca404 to
7f63e55
Compare
5 participants
Add new parameter for SW to force DMI L1 exit on IPC request.
Associated with: zephyrproject-rtos/zephyr#66042
Separating two new functions force and allow l1 to have the current state with separated functions in the power manager so that SOF can call these functions via IPC DMI_FORCE_L1_EXIT. DMA sometimes slows down and does not perform, therefore the workaround is to switch off l1. Change related to the addition of a new parameter to force DMI L1 exit on IPC request.