Skip to content

mt8195 fixups #8691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kv2019i merged 3 commits into from
Mar 11, 2024
Merged

mt8195 fixups #8691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
56eddfe
mt8195: Bump task stack size for Google AEC
andyross Aug 31, 2023
cac0fdc
topology1/mt8195: Add Graphviz output markers
andyross Nov 15, 2023
291dcb7
mt8195: Disable GOOGLE AEC MOCK by default
andyross Dec 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/arch/xtensa/configs/override/mt8195_chrome_google_rtc_rtnr.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
CONFIG_COMP_RTNR=y
CONFIG_COMP_GOOGLE_RTC_AUDIO_PROCESSING=y
CONFIG_GOOGLE_RTC_AUDIO_PROCESSING_MOCK=y
CONFIG_COMP_MUX=y
4 changes: 4 additions & 0 deletions src/platform/mt8195/include/platform/lib/memory.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,11 @@
#define HEAP_BUF_ALIGNMENT DCACHE_LINE_SIZE

/** \brief EDF task's default stack size in bytes. */
#ifdef CONFIG_COMP_GOOGLE_RTC_AUDIO_PROCESSING
#define PLATFORM_TASK_DEFAULT_STACK_SIZE 8192
#else
#define PLATFORM_TASK_DEFAULT_STACK_SIZE 3072
#endif
Copy link
Collaborator

@lyakh lyakh Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, that's a bit heavy-handed, but well, if it works...

Copy link
Contributor Author

@andyross andyross Jan 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually the only place to put a stack size in XTOS SOF. FWIW the same kind of issue exists with the DP scheduler too, which shares a single worker thread for a core and thus has to be sized to the largest stack consumer that it might run, which is likewise done with a global setting, though there AEC was the first consumer so it got an 8k stack in the first version.


#if !defined(__ASSEMBLER__) && !defined(LINKER)

Expand Down
4 changes: 4 additions & 0 deletions tools/topology/topology1/sof-mt8195-mt6359-rt1019-rt5682.m4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ include(`sof/tokens.m4')
# Include DSP configuration
include(`platform/mediatek/mt8195.m4')

DEBUG_START

#
# Define the demux configure
#
Expand Down Expand Up @@ -187,3 +189,5 @@ DAI_CONFIG(AFE, 2, 0, AFE_SOF_UL4,

DAI_CONFIG(AFE, 3, 0, AFE_SOF_UL5,
AFE_CONFIG(AFE_CONFIG_DATA(AFE, 3, 48000, 2, s16le)))

DEBUG_END