module_adapter: fix double-free of base_cfg_ext data #8790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kv2019i
requested review from
andyross,
lyakh,
marcinszkudlinski and
yongzhi1
Collaborator
Author
|
This PR addresses the double-free on heap as seen on https://sof-ci.01.org/sofpr/PR8764/build2195/devicetest/index.html?model=TGLU_RVP_NOCODEC-ipc4&testcase=multiple-pause-resume-50 |
This was referenced Jan 25, 2024
jxstelter
approved these changes
Jan 25, 2024
lgirdwood
approved these changes
Jan 25, 2024
Collaborator
Author
|
System/merge/build failed on 06_00_TestHdaCodecLoopback on TGL, but seems to be an infra issue ("Unhandled Exception: System.BadImageFormatException: Could not load file or assembly" -- the test run itself went through on the DSP without errors). |
tmleman
approved these changes
Jan 25, 2024
Fix handling of input_pins free. Module reset can be called multiple times, so move the resource release to module_adapter_free(). Fixes: 7046004 ("module_adapter_ipc4: Save and pre-parse base_cfg_ext data") Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
force-pushed
the
202401-fix-module-adapter3
branch
from
09b8b65 to
08edfff
Compare
Collaborator
Author
|
V2:
|
lyakh
approved these changes
Jan 25, 2024
This was referenced Jan 25, 2024
Collaborator
A lot more sample failures listed in bug number #8721 which was missing from the description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix handling of input_pins free. Module reset can be called multiple times, so move the resource release to module_adapter_free().
Fixes: 7046004 ("module_adapter_ipc4: Save and pre-parse base_cfg_ext data")