Skip to content

math: avoid re-initialising variables every loop iteration #8999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kv2019i merged 1 commit into from
Apr 3, 2024
Merged

math: avoid re-initialising variables every loop iteration #8999

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/math/auditory/auditory.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ int psy_get_mel_filterbank(struct psy_mel_filterbank *fb)
int32_t up_slope;
int32_t down_slope;
int32_t slope;
int32_t scale;
int32_t scale_inv;
int32_t scale = ONE_Q16;
int32_t scale_inv = ONE_Q16;
int16_t *mel;
int16_t mel_start;
int16_t mel_end;
Expand Down Expand Up @@ -137,6 +137,8 @@ int psy_get_mel_filterbank(struct psy_mel_filterbank *fb)
if (fb->scratch_length1 < fb->half_fft_bins)
return -ENOMEM;

fb->scale_log2 = 0;

mel = fb->scratch_data1;
for (i = 0; i < fb->half_fft_bins; i++) {
f = fb->samplerate * i / fb->fft_bins;
Expand Down Expand Up @@ -164,10 +166,6 @@ int psy_get_mel_filterbank(struct psy_mel_filterbank *fb)
}

scale = Q_MULTSR_32X32((int64_t)scale, scale_inv, 16, 16, 16);
} else {
scale = ONE_Q16;
scale_inv = ONE_Q16;
fb->scale_log2 = 0;
}
for (j = 0; j < fb->half_fft_bins; j++) {
up_slope = (((int32_t)mel[j] - left_mel) << 15) / delta_cl; /* Q17.15 */
Expand Down