audio: base_fw: add platform layer to fw_config data #9059
Conversation
Fix spelling in platform_basefw_hw_config() documentation. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Some of the IPC4 FW_CONFIG fields are platform specific and cannot be filled with generic code. Handle this data by adding a call to platform_basefw_fw_config() and add an implementation for all current platforms with IPC4 support. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
RanderWang,
dbaluta,
lbetlej,
lgirdwood,
marcinszkudlinski,
mmaka1,
pblaszko and
plbossart
as code owners
| { | ||
| struct sof_tlv *tuple = (struct sof_tlv *)data; | ||
|
|
||
| tlv_value_uint32_set(tuple, IPC4_SLOW_CLOCK_FREQ_HZ_FW_CFG, IPC4_ALH_CAVS_1_8); |
There was a problem hiding this comment.
This cannot be right, right?
see the original code:
tuple = tlv_next(tuple);
tlv_value_uint32_set(tuple,
IPC4_SLOW_CLOCK_FREQ_HZ_FW_CFG,
clock_get_freq(CPU_LOWEST_FREQ_IDX));
tuple = tlv_next(tuple);
tlv_value_uint32_set(tuple, IPC4_SLOW_CLOCK_FREQ_HZ_FW_CFG, IPC4_ALH_CAVS_1_8);The first set of IPC4_SLOW_CLOCK_FREQ_HZ_FW_CFG looks valid, the second (and the one which got moved) is not.
There was a problem hiding this comment.
It is introduced by
3efd780 ("ipc4: add basefw component support")
so it is introduced alongside of the file itself.
There was a problem hiding this comment.
@ujfalusi I'm not touching the values here, just moving them around as-is. That certainly looks wrong, but haven't dug into details yet. Linux driver is not using this, so hard to say much about this.
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Lets do the code move 1st, we can then followup if we thing data is wrong (as its passing CI).
@softwarecki pls review.
|
There's more incoming, now still as draft in #9060 |
|
Let's go directly with #9060 , closing this one. |
3 participants
Build on foundation set in #9012