Skip to content

Conversation

@marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented May 9, 2024

Lower the log level of tr_err(&hdma_tr, "hda_dma_link_check_xrun(): underrun detected"); to tr_warn().

Underruns are expected when testing pause/start and these errors can hide other, "real", not expected errors; more details in thesofproject/sof-test#1188

This "fixes" 2019 commit 293dfe2 ("hda-dma: refactor xrun handling")

Note this driver is not in the main branch anymore, removed by commit 59028ad ("drivers: Intel: remove Intel XTOS drivers")

Lower the log level of `tr_err(&hdma_tr, "hda_dma_link_check_xrun():
underrun detected");` to `tr_warn()`.

Underruns are expected when testing pause/start and these errors can
hide other, "real", not expected errors; more details in
thesofproject/sof-test#1188

This "fixes" 2019 commit 293dfe2 ("hda-dma: refactor xrun
handling")

Note this driver is not in the main branch anymore, removed by commit
59028ad ("drivers: Intel: remove Intel XTOS drivers")

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb marc-hb changed the title drivers: Intel: hda-dma: lower log level of "underrun detected" [STABLE-v2.2] drivers: Intel: hda-dma: lower log level of "underrun detected" May 9, 2024
@marc-hb marc-hb marked this pull request as ready for review May 9, 2024 19:43
@marc-hb marc-hb requested review from lyakh, ranj063 and ujfalusi May 9, 2024 19:43
@lgirdwood
Copy link
Member

@wszypelt @lrudyX not sure if internal I will test older stable branches ? if not, good to merge ?

@marc-hb
Copy link
Collaborator Author

marc-hb commented May 14, 2024

not sure if internal I will test older stable branches ?

It will always try and always fail because the build configuration has become too different. I filed internal issue PTS-45980 one year ago about this

@marc-hb marc-hb requested a review from andyross May 14, 2024 15:00
@wszypelt
Copy link

@lgirdwood Unfortunately, it is true, the issue still occurs

@marc-hb marc-hb merged commit 64416ba into thesofproject:stable-v2.2 May 14, 2024
@marc-hb marc-hb deleted the underrun-warn-22 branch May 14, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants