Audio: DRC: Tune: DRC setup scripts to module directory #9188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singalsu
requested review from
a team,
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
singalsu
commented
Jun 4, 2024
The purpose of this patch is to consolidate all the files those belong to the DRC module. The top level function names are changed to have sof_ prefix to avoid conflict with possible other similar files. Note: A small fix is needed after similar patch for EQ is merged since some functions for DRC blob are used from there. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch adds checks and errors for fopen() failures. The check is useful with setup scripts paths changes. Aborting the script avoids the errors in blob exports to be missed. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
lgirdwood
approved these changes
Jun 25, 2024
| rmpath(common); | ||
| rmpath(eq); | ||
| end | ||
| end |
Member
There was a problem hiding this comment.
This is fine for the moment (short term), but in the long term we need a script that sets the Matlab/Octave environment and paths up (we have a source script for Zephyr today- so something similar). See https://docs.octave.org/v4.2.1/Startup-Files.html as these mechanism can be used
cujomalainey
approved these changes
Jun 25, 2024
Member
|
SOFCI TEST |
Collaborator
|
@wszypelt Can you check, quick run seems stuck on this PR that should not impact quickbuild tests. |
|
@kv2019i Intel intel CI system, all good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.