Skip to content

copier: update buffer format on bind #9197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iganakov wants to merge 1 commit into from
Closed

copier: update buffer format on bind #9197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 26 additions & 15 deletions src/audio/copier/copier.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,8 +662,6 @@ static int copier_set_sink_fmt(struct comp_dev *dev, const void *data,
const struct ipc4_copier_config_set_sink_format *sink_fmt = data;
struct processing_module *mod = comp_get_drvdata(dev);
struct copier_data *cd = module_get_private_data(mod);
struct list_item *sink_list;
struct comp_buffer *sink;

if (max_data_size < sizeof(*sink_fmt)) {
comp_err(dev, "error: max_data_size %d should be bigger than %d", max_data_size,
Expand Down Expand Up @@ -693,19 +691,6 @@ static int copier_set_sink_fmt(struct comp_dev *dev, const void *data,
&sink_fmt->sink_fmt, ipc4_gtw_none,
ipc4_bidirection);

/* update corresponding sink format */
list_for_item(sink_list, &dev->bsink_list) {
int sink_id;

sink = container_of(sink_list, struct comp_buffer, source_list);

sink_id = IPC4_SINK_QUEUE_ID(buf_get_id(sink));
if (sink_id == sink_fmt->sink_id) {
ipc4_update_buffer_format(sink, &sink_fmt->sink_fmt);
break;
}
}

return 0;
}

Expand Down Expand Up @@ -990,6 +975,31 @@ static int copier_get_hw_params(struct comp_dev *dev, struct sof_ipc_stream_para
return dai_common_get_hw_params(dd, dev, params, dir);
}

static int copier_bind(struct processing_module *mod, void *data)
{
struct copier_data *cd = module_get_private_data(mod);
struct comp_dev *dev = mod->dev;
struct ipc4_module_bind_unbind *bu = data;
uint32_t src_queue_id = bu->extension.r.src_queue;
struct list_item *sink_list;
struct comp_buffer *sink;

/* update corresponding sink format */
list_for_item(sink_list, &dev->bsink_list) {
int sink_id;

sink = container_of(sink_list, struct comp_buffer, source_list);
sink_id = IPC4_SRC_QUEUE_ID(buf_get_id(sink));
if (sink_id == src_queue_id) {
ipc4_update_buffer_format(sink, &cd->out_fmt[sink_id]);
return 0;
}
}

comp_err(dev, "No sink buffer found for src_queue=%d", src_queue_id);
return -ENODEV;
}

static int copier_unbind(struct processing_module *mod, void *data)
{
struct copier_data *cd = module_get_private_data(mod);
Expand Down Expand Up @@ -1023,6 +1033,7 @@ static const struct module_interface copier_interface = {
.free = copier_free,
.set_configuration = copier_set_configuration,
.get_configuration = copier_get_configuration,
.bind = copier_bind,
.unbind = copier_unbind,
.endpoint_ops = &copier_endpoint_ops,
};
Expand Down