src: base_fw: adjust ssp copier init flow for ptl (with Zephyr update) #9220
Conversation
dnikodem
changed the title
dnikodem
force-pushed
the
adjust_ssp_copier_flow
branch
from
e2c3513 to
b1bdb59
Compare
dnikodem
changed the title
dnikodem
force-pushed
the
adjust_ssp_copier_flow
branch
from
b1bdb59 to
8388e2b
Compare
dnikodem
requested review from
RanderWang,
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
marcinszkudlinski,
mmaka1,
pblaszko and
plbossart
as code owners
dnikodem
force-pushed
the
adjust_ssp_copier_flow
branch
2 times, most recently
from
114b0bd to
17ffa93
Compare
This commit introduces a new constant 'I2S_VER_30_PTL' that describes specific I2S blob configurations for Intel ACE30 PTL. Signed-off-by: Damian Nikodem <damian.nikodem@intel.com>
Virtual index value for I2S on PTL contains two information: - time slot group index : 4 - i2s instance : 4 In order to correctly configure the dai api, both of the above values should be retained. Update zephyr branch to commit: a2386efbce1 drivers: ssp: update SSP driver to support Intel ACE30 PTL Signed-off-by: Damian Nikodem <damian.nikodem@intel.com>
dnikodem
force-pushed
the
adjust_ssp_copier_flow
branch
from
17ffa93 to
7ea4f27
Compare
dnikodem
changed the title
dnikodem
changed the title
kv2019i
changed the title
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
I think in this type of cases, the west.yml update of Zephyr shouldn't be baked into the same PR (see comment inline). But given we have a clean CI pass, I think we can proceed to merge this one and move on. But a note for future PRs.
|
|
||
| /* Specifies I2S IPC4 version for PTL platform */ | ||
| static const uint32_t I2S_VER_30_PTL = 0x40000; | ||
|
|
There was a problem hiding this comment.
This would ideally be put in some Intel-specific file, but as we have no such file now, base_fw.h is probably the best fit. But if we get more of these, we need to add base_fw_intel.h and have these there (and also if there are any build-time dependencies).
| - name: zephyr | ||
| repo-path: zephyr | ||
| revision: 0a3f2f0397a86425cc7d12fa3a0c0ab8020d80e1 | ||
| revision: a2386efbce1866613f7c714b958a159364dc5f37 |
There was a problem hiding this comment.
This west update could be done as a separate PR and then do this PR. Recommendation is to update west.yml and code only and only if Zephyr has a interface changes (i.e. something SOF uses is changed). In this case, it seems this is a new capabiltiy, so Zephyr could be update dfirst, and then this PR could be done on top once Zephyr baseline has "tdm_slot_group".
|
New Zephyr panic pinpointed to this: |
6 participants
Regarding to zephyrproject-rtos/zephyr#74030 there is necessary to pass properly v_index value.
In addition, PTL has a new version of the IPC4 blob, which will be configured in the TLV information
Necessary zephyr changes:
This PR also changes the West version to be consistent with the changes from PR 74030