Skip to content

library_manager: add missing "depends on CONFIG_LLEXT" #9222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marc-hb wants to merge 1 commit into from
Closed

library_manager: add missing "depends on CONFIG_LLEXT" #9222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/library_manager/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ menu "Library Manager"
config LIBRARY_MANAGER
bool "Library Manager Support"
default n
depends on CONFIG_LLEXT
Copy link
Collaborator

@lyakh lyakh Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct. The library manager can also be used for LMDK and IADK modules, which don't need LLEXT

Copy link
Collaborator Author

@marc-hb marc-hb Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was even more incorrect because it should have been:

Suggested change
depends on CONFIG_LLEXT
depends on LLEXT

depends on IPC_MAJOR_4
help
This is support for dynamic modules loading.
Expand Down