Skip to content

boards: config: add U8 bit format support for PTL #9257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 1 commit into from
Jun 26, 2024
Merged

boards: config: add U8 bit format support for PTL #9257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/boards/intel_adsp_ace30_ptl.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ CONFIG_L3_HEAP=y
CONFIG_RIMAGE_SIGNING_SCHEMA="ptl"

CONFIG_FORMAT_CONVERT_HIFI3=n
CONFIG_FORMAT_U8=y
CONFIG_PCM_CONVERTER_FORMAT_U8=y
Copy link
Collaborator

@lyakh lyakh Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious, why don't ACE 1.5 and 2.0 support it?

Copy link
Contributor Author

@dnikodem dnikodem Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good question - support for U8 was tested on PTL, not sure if it is working on ACE1.5/2.0 as well (It is globally disabled in Kconfig files). From the code analysis, it appears that this format could be supported for both ACE3.0 and ACE1.5/2.0 - but the question is: do we have any requirement for support this on ACE1.5/2.0?

CONFIG_PCM_CONVERTER_FORMAT_S16_C16_AND_S16_C32=y
CONFIG_PCM_CONVERTER_FORMAT_S16_C32_AND_S32_C32=y
CONFIG_PCM_CONVERTER_FORMAT_S16_C32_AND_S24_C32=y
Expand Down