Topology2: fix soundwire audio formats #9328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to use input_audio_format and output_audio_format. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
…BITS These two variables should only be used on the link side. It makes no sense to use them on the host-facing side of the DAI copier. FIXME: do we need to use 3 formats for the ALH copiers, in most cases there's really a need for a 32-bit format only? Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
The ALH copier only supports 32bits stereo on capture. All the additional formatls on the host copiers make no sense, and we also don't need to generate 4ch on the host side. It looks like the addition of the 1ch support was also problematic since the link always operates with 2ch. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Member
Author
bardliao
approved these changes
Jul 25, 2024
Member
Author
|
I'll tag as ready for review, in the hope that this will attract more feedback |
Member
Author
|
SOFCI TEST |
lgirdwood
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The topology2 maintenance continues to be problematic, we've added a number of "features" that were not completed to the end, due to copy-paste inertia and possibly lack of reviews.
While trying to enable the CHAIN_DMA mode for SoundWire, I found way too many complicated and unnecessary configurations.
This is an extremely invasive PR done with my extremely limited understanding of topology2, this needs careful testing and reviews.
FIXME: do we need to deal with multiple formats or can we assume that the ALH copiers always deal internally with 32-bits? I don't see the point of multiple options, only the host-copier host-facing formats should allow for more formats and conversions.